Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1372883002: Revert of Move status bar color setting to ChromeActivity. (Closed)

Created:
5 years, 2 months ago by Benoit L
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move status bar color setting to ChromeActivity. (patchset #5 id:70001 of https://codereview.chromium.org/1364043003/ ) Reason for revert: Broke CustomTabActivityTest#testToolbarColor, see crbug.com/536698 for the tracking bug, and crrev.com/1370003002 for a potential fix. Original issue's description: > Move status bar color setting to ChromeActivity. > > BUG=535235 > > Committed: https://crrev.com/4b74179f72ea6c4f0b1539a8c31277e8d29f7711 > Cr-Commit-Position: refs/heads/master@{#350961} TBR=yusufo@chromium.org,tedchoc@chromium.org,aurimas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535235 Committed: https://crrev.com/c219d1def47875bf0569c7f931620e6c9f94a801 Cr-Commit-Position: refs/heads/master@{#351042}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Benoit L
Created Revert of Move status bar color setting to ChromeActivity.
5 years, 2 months ago (2015-09-28 09:11:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372883002/1
5 years, 2 months ago (2015-09-28 09:12:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 09:13:26 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 09:14:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c219d1def47875bf0569c7f931620e6c9f94a801
Cr-Commit-Position: refs/heads/master@{#351042}

Powered by Google App Engine
This is Rietveld 408576698