Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1372863003: VM: Add uint32 array intrinsics. (Closed)

Created:
5 years, 2 months ago by Florian Schneider
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Add uint32 array intrinsics. Since the VM's compact map implementation uses Uint32List internally, this helps programs that use hash maps and -sets. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b2be30b4a17879728c8343e773ae3e71aa3c594c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M runtime/vm/intrinsifier.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 2 months ago (2015-10-05 14:24:35 UTC) #2
rmacnak
lgtm
5 years, 2 months ago (2015-10-05 17:23:17 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as b2be30b4a17879728c8343e773ae3e71aa3c594c (presubmit successful).
5 years, 2 months ago (2015-10-06 08:17:35 UTC) #4
Florian Schneider
5 years, 2 months ago (2015-10-06 16:36:59 UTC) #5
Message was sent while issue was closed.
This gives ~10% on precompiled dart2js (hellohtml).

Powered by Google App Engine
This is Rietveld 408576698