tools/clang/plugins/FindBadConstructsAction.cpp - Issue 1372833002: Update the clang plugin to optionally enforce rules for Blink code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 1372833002: Update the clang plugin to optionally enforce rules for Blink code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ooookay, emplace it is Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/plugins/FindBadConstructsAction.cpp

diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp

index 5595cde3037840351962e4b81cf27f89333d6a7f..0f6fbd5d61d5d81270a277f51a564d0030a9580f 100644

--- a/tools/clang/plugins/FindBadConstructsAction.cpp

+++ b/tools/clang/plugins/FindBadConstructsAction.cpp

@@ -49,8 +49,11 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,

if (args[i] == "check-base-classes") {

// TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.

options_.check_base_classes = true;

- } else if (args[i] == "enforce-blink") {

- options_.enforce_blink = true;

+ } else if (args[i] == "enforce-overriding-blink") {

+ options_.enforce_overriding_blink = true;

+ } else if (args[i] == "enforce-in-thirdparty-webkit") {

+ options_.enforce_in_thirdparty_webkit = true;

+ options_.enforce_overriding_blink = true;

} else if (args[i] == "check-enum-last-value") {

// TODO(tsepez): Enable this by default once http://crbug.com/356815

// and http://crbug.com/356816 are fixed.

« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »