Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/clang/plugins/ChromeClassTester.h

Issue 1372833002: Update the clang plugin to optionally enforce rules for Blink code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ooookay, emplace it is Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/ChromeClassTester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.h
diff --git a/tools/clang/plugins/ChromeClassTester.h b/tools/clang/plugins/ChromeClassTester.h
index 6b5cdf3577ea3a71d85f87b0995a1af406e94a00..e3d7e3caab209d83eda315c16fc86de14ed7134c 100644
--- a/tools/clang/plugins/ChromeClassTester.h
+++ b/tools/clang/plugins/ChromeClassTester.h
@@ -85,10 +85,14 @@ class ChromeClassTester : public clang::ASTConsumer {
clang::DiagnosticsEngine& diagnostic_;
// List of banned namespaces.
- std::vector<std::string> banned_namespaces_;
+ std::set<std::string> banned_namespaces_;
+
+ // List of directories allowed even though their parent directories are in
+ // |banned_directories_|, below.
+ std::set<std::string> allowed_directories_;
// List of banned directories.
- std::vector<std::string> banned_directories_;
+ std::set<std::string> banned_directories_;
// List of types that we don't check.
std::set<std::string> ignored_record_names_;
« no previous file with comments | « no previous file | tools/clang/plugins/ChromeClassTester.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698