Update the clang plugin to optionally enforce rules for Blink code.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <algorithm>
@@ skipping 132 matching lines @@
   // On Posix, realpath() has made the path absolute.  On Windows, this isn't
   // necessarily true, so prepend a '/' to the path to make sure the
   // banned_directories_ loop below works correctly.
   // This turns e.g. "gen/dir/file.cc" to "/gen/dir/file.cc" which lets the
   // "/gen/" banned_dir work.
   // This seems simpler than converting to utf16, calling GetFullPathNameW(),
   // and converting back to utf8.
   filename.insert(filename.begin(), '/');
 #endif
 
+  for (const std::string& allowed_dir : allowed_directories_) {
+    // If any of the allowed directories occur as a component in filename,
+    // this file is allowed.
+    assert(allowed_dir.front() == '/' && "Allowed dir must start with '/'");
+    assert(allowed_dir.back() == '/' && "Allowed dir must end with '/'");
+
+    if (filename.find(allowed_dir) != std::string::npos)
+      return false;
+  }
+
   for (const std::string& banned_dir : banned_directories_) {
     // If any of the banned directories occur as a component in filename,
     // this file is rejected.
     assert(banned_dir.front() == '/' && "Banned dir must start with '/'");
     assert(banned_dir.back() == '/' && "Banned dir must end with '/'");
 
     if (filename.find(banned_dir) != std::string::npos)
       return true;
   }
 
@@ skipping 21 matching lines @@
 
   if (ends_with(filename, ".cc") || ends_with(filename, ".cpp") ||
       ends_with(filename, ".mm")) {
     return true;
   }
 
   return false;
 }
 
 void ChromeClassTester::BuildBannedLists() {
-  banned_namespaces_.push_back("std");
-  banned_namespaces_.push_back("__gnu_cxx");
+  banned_namespaces_.insert("std");

[dcheng, 2015/10/01 21:42:48]

IMO, if you're going to change all these, you may as well use emplace.

[Avi (use Gerrit), 2015/10/01 21:52:06]

Wouldn't the same rules about no C++11 library features apply here?

[dcheng, 2015/10/01 21:53:22]

Nope =)

The plugin already uses std::unique_ptr and stuff like that.

+  banned_namespaces_.insert("__gnu_cxx");
 
-  if (!options_.enforce_blink) {
-    banned_namespaces_.push_back("blink");
-    banned_namespaces_.push_back("WTF");
+  if (!options_.enforce_overriding_blink) {
+    banned_namespaces_.insert("blink");
+    banned_namespaces_.insert("WTF");
   }
 
-  banned_directories_.push_back("/third_party/");
-  banned_directories_.push_back("/native_client/");
-  banned_directories_.push_back("/breakpad/");
-  banned_directories_.push_back("/courgette/");
-  banned_directories_.push_back("/pdf/");
-  banned_directories_.push_back("/ppapi/");
-  banned_directories_.push_back("/usr/include/");
-  banned_directories_.push_back("/usr/lib/");
-  banned_directories_.push_back("/usr/local/include/");
-  banned_directories_.push_back("/usr/local/lib/");
-  banned_directories_.push_back("/testing/");
-  banned_directories_.push_back("/v8/");
-  banned_directories_.push_back("/dart/");
-  banned_directories_.push_back("/sdch/");
-  banned_directories_.push_back("/icu4c/");
-  banned_directories_.push_back("/frameworks/");
+  if (options_.enforce_in_thirdparty_webkit) {
+    allowed_directories_.insert("/third_party/WebKit/");
+  }
+
+  banned_directories_.insert("/third_party/");
+  banned_directories_.insert("/native_client/");
+  banned_directories_.insert("/breakpad/");
+  banned_directories_.insert("/courgette/");
+  banned_directories_.insert("/pdf/");
+  banned_directories_.insert("/ppapi/");
+  banned_directories_.insert("/usr/include/");
+  banned_directories_.insert("/usr/lib/");
+  banned_directories_.insert("/usr/local/include/");
+  banned_directories_.insert("/usr/local/lib/");
+  banned_directories_.insert("/testing/");
+  banned_directories_.insert("/v8/");
+  banned_directories_.insert("/dart/");
+  banned_directories_.insert("/sdch/");
+  banned_directories_.insert("/icu4c/");
+  banned_directories_.insert("/frameworks/");
 
   // Don't check autogenerated headers.
   // Make puts them below $(builddir_name)/.../gen and geni.
   // Ninja puts them below OUTPUT_DIR/.../gen
   // Xcode has a fixed output directory for everything.
-  banned_directories_.push_back("/gen/");
-  banned_directories_.push_back("/geni/");
-  banned_directories_.push_back("/xcodebuild/");
+  banned_directories_.insert("/gen/");
+  banned_directories_.insert("/geni/");
+  banned_directories_.insert("/xcodebuild/");
 
   // Used in really low level threading code that probably shouldn't be out of
   // lined.
   ignored_record_names_.insert("ThreadLocalBoolean");
 
   // A complicated pickle derived struct that is all packed integers.
   ignored_record_names_.insert("Header");
 
   // Part of the GPU system that uses multiple included header
   // weirdness. Never getting this right.
@@ skipping 68 matching lines @@
   return true;
 }
 
 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
   if (options_.warn_only)
     return DiagnosticsEngine::Warning;
 
   return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
                                             : DiagnosticsEngine::Warning;
 }