SkPDF: Implement drawImage*() properly

include/private/SkTHash.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkTHash_DEFINED
 #define SkTHash_DEFINED
 
@@ skipping 224 matching lines @@
     void foreach(Fn&& fn) {
         fTable.foreach([&fn](Pair* p){ fn(p->key, &p->val); });
     }
 
     // Call fn on every key/value pair in the table.  You may not mutate anything.
     template <typename Fn>  // f(K, V), f(const K&, V), f(K, const V&) or f(const K&, const V&).
     void foreach(Fn&& fn) const {
         fTable.foreach([&fn](const Pair& p){ fn(p.key, p.val); });
     }
 
+    // Call fn on every value in the table.  You may not mutate anything.
+    template <typename Fn>  // f(const V&) or f(V)
+    void foreachValue(Fn&& fn) const {

[mtklein, 2015/09/27 07:20:32]

What value does this add?  Can you not just ignore the key?

+        fTable.foreach([&fn](const Pair& p) { fn(p.val); });
+    }
+
 private:
     struct Pair {
         K key;
         V val;
         static const K& GetKey(const Pair& p) { return p.key; }
         static uint32_t Hash(const K& key) { return HashK(key); }
     };
 
     SkTHashTable<Pair, K> fTable;
 };
@@ skipping 37 matching lines @@
 
 private:
     struct Traits {
         static const T& GetKey(const T& item) { return item; }
         static uint32_t Hash(const T& item) { return HashT(item); }
     };
     SkTHashTable<T, T, Traits> fTable;
 };
 
 #endif//SkTHash_DEFINED