Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1372723002: Empty per_page_values shouldn't imply test success (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Remove dead code Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_trybot.py
diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py
index 1555cfe2bf6718a03db5e6fbc57a266e7a376d58..e482295778bb4d5e347ab2d7b837658bdb0be6cb 100644
--- a/scripts/slave/recipes/chromium_trybot.py
+++ b/scripts/slave/recipes/chromium_trybot.py
@@ -1366,6 +1366,25 @@ def GenTests(api):
)
yield (
+ api.test('telemetry_gpu_harness_failure') +
+ props(
+ mastername='tryserver.chromium.linux',
+ buildername='linux_chromium_rel_ng',
+ ) +
+ api.platform.name('linux') +
+ api.override_step_data(
+ 'maps_pixel_test on NVIDIA GPU on Linux (with patch) on Linux',
+ api.test_utils.canned_telemetry_gpu_output(
+ passing=False, is_win=False, swarming=True,
+ empty_per_page_values=True),
+ retcode=255) +
+ api.override_step_data('analyze',
+ api.json.output({'status': 'Found dependency',
+ 'targets': gpu_targets,
+ 'build_targets': gpu_targets}))
+ )
+
+ yield (
api.test('telemetry_gpu_swarming_error') +
props(
mastername='tryserver.chromium.mac',

Powered by Google App Engine
This is Rietveld 408576698