Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2431)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json

Issue 1372723002: Empty per_page_values shouldn't imply test success (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Remove dead code Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_harness_failure.json ('k') | scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json
diff --git a/scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json b/scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json
index 2c334946bc5442653ce6631d2b531b8d7ac59913..8d4bea9d7ed63fe8e41f0f97c039a9cc2aa3a1bd 100644
--- a/scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json
+++ b/scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json
@@ -3260,6 +3260,7 @@
"name": "pixel_test on Intel GPU on Mac (with patch)",
"~followup_annotations": [
"step returned non-zero exit code: 255",
+ "@@@STEP_TEXT@<br/>failures:<br/>pixel_test on Intel GPU on Mac (entire test suite)<br/>@@@",
"@@@STEP_LOG_LINE@outdir_json@{@@@",
"@@@STEP_LOG_LINE@outdir_json@ \"0/results.json\": \"{\\\"per_page_values\\\": [{\\\"page_id\\\": 0, \\\"type\\\": \\\"success\\\"}, {\\\"page_id\\\": 1, \\\"type\\\": \\\"success\\\"}], \\\"pages\\\": {\\\"1\\\": {\\\"name\\\": \\\"Test.Test2\\\"}, \\\"0\\\": {\\\"name\\\": \\\"Test.Test1\\\"}}}\", @@@",
"@@@STEP_LOG_LINE@outdir_json@ \"summary.json\": \"{\\\"shards\\\": [{\\\"internal_failure\\\": false, \\\"failure\\\": false}]}\"@@@",
@@ -3985,5 +3986,325 @@
],
"cwd": "[SLAVE_BUILD]",
"name": "Upload to test-results [tab_capture_end2end_tests on NVIDIA GPU on Mac Retina (with patch) on Mac-10.9]"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[BUILD]/scripts/slave/bot_update.py",
+ "--master",
+ "tryserver.chromium.mac",
+ "--builder",
+ "mac_chromium_rel_ng",
+ "--slave",
+ "TestSlavename",
+ "--spec",
+ "cache_dir = None\nsolutions = [{'custom_vars': {'googlecode_url': 'svn://svn-mirror.golo.chromium.org/%s', 'nacl_trunk': 'svn://svn-mirror.golo.chromium.org/native_client/trunk', 'sourceforge_url': 'svn://svn-mirror.golo.chromium.org/%(repo)s', 'webkit_trunk': 'svn://svn-mirror.golo.chromium.org/blink/trunk'}, 'deps_file': 'DEPS', 'managed': True, 'name': 'src', 'url': 'svn://svn-mirror.golo.chromium.org/chrome/trunk/src'}]",
+ "--root",
+ "src",
+ "--revision_mapping_file",
+ "{\"src\": \"got_revision\", \"src/native_client\": \"got_nacl_revision\", \"src/third_party/webrtc\": \"got_webrtc_revision\", \"src/tools/swarming_client\": \"got_swarming_client_revision\", \"src/v8\": \"got_v8_revision\"}",
+ "--rietveld_server",
+ "https://codereview.chromium.org",
+ "--output_json",
+ "/path/to/tmp/json",
+ "--revision",
+ "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+ "--revision",
+ "src/native_client@d998e125e8253980d76e269b7982aeeefc1b9b50",
+ "--revision",
+ "src/third_party/webrtc@0f90628433546e61d9268596da93418c623137f4",
+ "--revision",
+ "src/tools/swarming_client@a0ee5d99f1d4b38ddaa4c759c837980b63b99566",
+ "--revision",
+ "src/v8@801ada225ddc271c132c3a35f03975671d43e399",
+ "--force"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "bot_update (without patch)",
+ "~followup_annotations": [
+ "@@@STEP_TEXT@Some step text@@@",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"did_run\": true, @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"patch_failure\": false, @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"patch_root\": \"src\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"properties\": {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_nacl_revision\": \"d998e125e8253980d76e269b7982aeeefc1b9b50\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_nacl_revision_cp\": \"refs/heads/master@{#274981}\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_revision_cp\": \"refs/heads/master@{#170242}\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_swarming_client_revision\": \"a0ee5d99f1d4b38ddaa4c759c837980b63b99566\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_swarming_client_revision_cp\": \"refs/heads/master@{#276089}\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_v8_revision\": \"801ada225ddc271c132c3a35f03975671d43e399\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_v8_revision_cp\": \"refs/heads/master@{#43426}\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_webrtc_revision\": \"0f90628433546e61d9268596da93418c623137f4\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"got_webrtc_revision_cp\": \"refs/heads/master@{#120644}\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ }, @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"root\": \"src\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"step_text\": \"Some step text\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[DEPOT_TOOLS]/gclient.py",
+ "runhooks"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "env": {
+ "GYP_DEFINES": "archive_gpu_tests=1 clang=1 component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' mac_sdk_min=10.10 target_arch=x64 test_isolation_mode=prepare use_goma=1"
+ },
+ "name": "gclient runhooks (without patch)"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[isolate]/resources/find_isolated_tests.py",
+ "--build-dir",
+ "[SLAVE_BUILD]/src/out/Release",
+ "--clean-isolated-files"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "clean isolated files (2)"
+ },
+ {
+ "allow_subannotations": true,
+ "cmd": [
+ "python",
+ "-u",
+ "[BUILD]/scripts/slave/clang_revision.py",
+ "--src-dir",
+ "[SLAVE_BUILD]/src",
+ "--output-json",
+ "/path/to/tmp/json"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "clang_revision (2)",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[BUILD]/scripts/slave/compile.py",
+ "--target",
+ "Release",
+ "--src-dir",
+ "[SLAVE_BUILD]/src",
+ "--build-tool",
+ "ninja",
+ "--compiler",
+ "goma-clang",
+ "--goma-dir",
+ "[BUILD]/goma",
+ "--goma-fail-fast",
+ "--goma-disable-local-fallback",
+ "--ninja-ensure-up-to-date",
+ "--",
+ "chrome",
+ "telemetry_gpu_test_run"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "compile (without patch)"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport glob\nimport sys\nwith open(sys.argv[1], 'w') as f:\n f.write('\\n'.join(glob.glob(sys.argv[2])))\n",
+ "/path/to/tmp/",
+ "[SLAVE_BUILD]/src/out/Release/*.isolated.gen.json"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "find isolated targets"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[isolate]/resources/isolate.py",
+ "[SLAVE_BUILD]/src/tools/swarming_client",
+ "batcharchive",
+ "--dump-json",
+ "/path/to/tmp/json",
+ "--isolate-server",
+ "https://isolateserver.appspot.com",
+ "--verbose",
+ "[SLAVE_BUILD]/src/out/Release/dummy_target_1.isolated.gen.json",
+ "[SLAVE_BUILD]/src/out/Release/dummy_target_2.isolated.gen.json"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "isolate tests (2)",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"dummy_target_1\": \"[dummy hash for dummy_target_1]\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"dummy_target_2\": \"[dummy hash for dummy_target_2]\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@SET_BUILD_PROPERTY@swarm_hashes@{\"dummy_target_1\": \"[dummy hash for dummy_target_1]\", \"dummy_target_2\": \"[dummy hash for dummy_target_2]\"}@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[SLAVE_BUILD]/src/tools/swarming_client/swarming.py",
+ "trigger",
+ "--swarming",
+ "https://chromium-swarm.appspot.com",
+ "--isolate-server",
+ "https://isolateserver.appspot.com",
+ "--priority",
+ "30",
+ "--shards",
+ "1",
+ "--task-name",
+ "pixel_test on Intel GPU on Mac (without patch)/Mac-10.8/[dummy has/mac_chromium_rel_ng/571",
+ "--dump-json",
+ "/path/to/tmp/json",
+ "--expiration",
+ "3600",
+ "--io-timeout",
+ "1200",
+ "--hard-timeout",
+ "3600",
+ "--dimension",
+ "cpu",
+ "x86-64",
+ "--dimension",
+ "gpu",
+ "8086:0116",
+ "--dimension",
+ "hidpi",
+ "0",
+ "--dimension",
+ "os",
+ "Mac-10.8",
+ "--dimension",
+ "pool",
+ "Chrome",
+ "--tag",
+ "buildername:mac_chromium_rel_ng",
+ "--tag",
+ "buildnumber:571",
+ "--tag",
+ "data:[dummy hash for telemetry_gpu_test]",
+ "--tag",
+ "gpu_test:1",
+ "--tag",
+ "master:tryserver.chromium.mac",
+ "--tag",
+ "name:pixel_test on Intel GPU on Mac (without patch)",
+ "--tag",
+ "os:Mac-10.8",
+ "--tag",
+ "patch_project:chromium",
+ "--tag",
+ "project:chromium",
+ "--tag",
+ "purpose:CQ",
+ "--tag",
+ "purpose:pre-commit",
+ "--tag",
+ "rietveld:https://codereview.chromium.org/12853011/#ps1",
+ "--tag",
+ "stepname:pixel_test on Intel GPU on Mac (without patch)",
+ "--user",
+ "commit-bot@chromium.org",
+ "[dummy hash for telemetry_gpu_test]",
+ "--",
+ "pixel",
+ "--show-stdout",
+ "--browser=release",
+ "-v",
+ "--use-devtools-active-port",
+ "--build-revision",
+ "f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+ "--download-refimg-from-cloud-storage",
+ "--refimg-cloud-storage-bucket",
+ "chromium-gpu-archive/reference-images",
+ "--os-type",
+ "mac",
+ "--test-machine-name",
+ "mac_chromium_rel_ng",
+ "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
+ "--story-filter=pixel\\_test\\ on\\ Intel\\ GPU\\ on\\ Mac\\ \\(entire\\ test\\ suite\\)",
+ "--output-format",
+ "json",
+ "--output-dir",
+ "${ISOLATED_OUTDIR}"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "[trigger] pixel_test on Intel GPU on Mac (without patch)",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"base_task_name\": \"pixel_test on Intel GPU on Mac (without patch)/Mac-10.8/[dummy has/mac_chromium_rel_ng/571\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"tasks\": {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"pixel_test on Intel GPU on Mac (without patch)/Mac-10.8/[dummy has/mac_chromium_rel_ng/571\": {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"shard_index\": 0, @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"task_id\": \"10000\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"view_url\": \"https://chromium-swarm.appspot.com/user/task/10000\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ }@@@",
+ "@@@STEP_LOG_LINE@json.output@ }@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@STEP_LINK@shard #0@https://chromium-swarm.appspot.com/user/task/10000@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[SLAVE_BUILD]/src/tools/swarming_client/swarming.py",
+ "collect",
+ "--swarming",
+ "https://chromium-swarm.appspot.com",
+ "--decorate",
+ "--print-status-updates",
+ "--shards",
+ "1",
+ "pixel_test on Intel GPU on Mac (without patch)/Mac-10.8/[dummy has/mac_chromium_rel_ng/571",
+ "--task-output-dir",
+ "/path/to/tmp/"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "pixel_test on Intel GPU on Mac (without patch)",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@outdir_json@{@@@",
+ "@@@STEP_LOG_LINE@outdir_json@ \"0/results.json\": \"{\\\"per_page_values\\\": [{\\\"page_id\\\": 0, \\\"type\\\": \\\"success\\\"}, {\\\"page_id\\\": 1, \\\"type\\\": \\\"success\\\"}], \\\"pages\\\": {\\\"1\\\": {\\\"name\\\": \\\"Test.Test2\\\"}, \\\"0\\\": {\\\"name\\\": \\\"Test.Test1\\\"}}}\", @@@",
+ "@@@STEP_LOG_LINE@outdir_json@ \"summary.json\": \"{\\\"shards\\\": [{\\\"internal_failure\\\": false, \\\"failure\\\": false}]}\"@@@",
+ "@@@STEP_LOG_LINE@outdir_json@}@@@",
+ "@@@STEP_LOG_END@outdir_json@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "import sys; sys.exit(1)"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "pixel_test on Intel GPU on Mac",
+ "~followup_annotations": [
+ "step returned non-zero exit code: 1",
+ "@@@STEP_TEXT@<br/>failures:<br/>pixel_test on Intel GPU on Mac (entire test suite)<br/>@@@",
+ "@@@STEP_FAILURE@@@",
+ "@@@SET_BUILD_PROPERTY@failure_type@\"TEST_FAILURE\"@@@",
+ "@@@SET_BUILD_PROPERTY@failure_hash@\"8cdd83cc2af010d5e2c60792a87d697a499fe98c\"@@@"
+ ]
+ },
+ {
+ "name": "$final_result",
+ "reason": "1 out of 1 aggregated steps failed. Failures: Step('pixel_test on Intel GPU on Mac') failed with return_code 1",
+ "status_code": 1
}
]
« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_harness_failure.json ('k') | scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698