Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/gpu/download_and_test.py

Issue 1372723002: Empty per_page_values shouldn't imply test success (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Rebased to depend on https://codereview.chromium.org/1366353002/ Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json ('k') | scripts/slave/recipes/gpu/download_and_test.expected/failures_keeps_going.json » ('j') | scripts/slave/recipes/gpu/download_and_test.expected/linux_debug.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/gpu/download_and_test.py
diff --git a/scripts/slave/recipes/gpu/download_and_test.py b/scripts/slave/recipes/gpu/download_and_test.py
index 93c7880d83b9d890b56ad9b90b4ebd3b766b2df4..d8dd2c250c3a40ccd3ebf50d8f35fac819a0a526 100644
--- a/scripts/slave/recipes/gpu/download_and_test.py
+++ b/scripts/slave/recipes/gpu/download_and_test.py
@@ -84,7 +84,20 @@ def GenTests(api):
props('linux', 'Release') +
api.platform.name('linux') +
api.step_data('content_gl_tests', retcode=1) +
- api.step_data('maps_pixel_test', retcode=1)
+ api.step_data('maps_pixel_test',
+ api.test_utils.canned_telemetry_gpu_output(
Sergiy Byelozyorov 2015/09/28 13:55:29 why was this test changed?
luqui 2015/09/28 17:33:35 In order to pass per_page_values correctly, which
+ passing=False, is_win=False, swarming=False))
+ )
+
+ yield (
+ api.test('telemetry_gpu_test_harness_failure') +
+ props('linux', 'Release') +
+ api.platform.name('linux') +
+ api.step_data('maps_pixel_test',
+ api.test_utils.canned_telemetry_gpu_output(
+ passing=False, is_win=False, swarming=False,
+ empty_per_page_values=True),
+ retcode=255)
)
win_fyi_hashes = api.gpu.dummy_win_fyi_swarm_hashes
« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json ('k') | scripts/slave/recipes/gpu/download_and_test.expected/failures_keeps_going.json » ('j') | scripts/slave/recipes/gpu/download_and_test.expected/linux_debug.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698