Empty per_page_values shouldn't imply test success

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 import string
 
 
 class Test(object):
   """
@@ skipping 1227 matching lines @@
 
   def compile_targets(self, _):
     # TODO(sergiyb): Build 'chrome_public_apk' instead of 'chrome' on Android.
     return ['chrome', 'telemetry_gpu_test_run']  # pragma: no cover
 
   def run(self, api, suffix):  # pylint: disable=R0201
     kwargs = self._runtest_kwargs.copy()
     kwargs['args'].extend(['--output-format', 'json',
                            '--output-dir', api.raw_io.output_dir()])
     step_test_data=lambda: api.test_utils.test_api.canned_telemetry_gpu_output(
-        passing=False, is_win=api.platform.is_win)
+        passing=True, is_win=api.platform.is_win)
     try:
       api.isolate.run_telemetry_test(
           'telemetry_gpu_test',
           self.target_name,
           self._revision,
           self._webkit_revision,
           name=self._step_name(suffix),
           spawn_dbus=True,
           step_test_data=step_test_data,
           **self._runtest_kwargs)
     finally:
       step_result = api.step.active_result
       self._test_runs[suffix] = step_result
 
       try:
         res = api.json.loads(step_result.raw_io.output_dir['results.json'])
-        self._failures[suffix] = [res['pages'][str(value['page_id'])]['name']
-                                  for value in res['per_page_values']
-                                  if value['type'] == 'failure']
+        failures = [res['pages'][str(value['page_id'])]['name']
+                   for value in res['per_page_values']
+                   if value['type'] == 'failure']
+        if not failures and step_result.retcode != 0:
+          failures = ['%s (entire test suite)' % self.name]
 
+        self._failures[suffix] = failures
         self._valid[suffix] = True
       except (ValueError, KeyError, AttributeError):  # pragma: no cover
         self._valid[suffix] = False
 
       if self._valid[suffix]:
         step_result.presentation.step_text += api.test_utils.format_step_text([
           ['failures:', self._failures[suffix]]
         ])
 
   def has_valid_results(self, api, suffix):
@@ skipping 35 matching lines @@
         title=self._step_name(suffix), isolated_hash=isolated_hash,
         extra_args=args)
 
   def validate_task_results(self, api, step_result):
     results = getattr(step_result, 'telemetry_results', None) or {}
 
     try:
       failures = [results['pages'][str(value['page_id'])]['name']
                   for value in results['per_page_values']
                   if value['type'] == 'failure']
+      if not failures and step_result.retcode != 0:
+        failures = ['%s (entire test suite)' % self.name]
 
       valid = True
     except (ValueError, KeyError) as e:  # pragma: no cover
       step_result.presentation.logs['invalid_results_exc'] = [str(e)]
       valid = False
       failures = None
 
     if valid:
       step_result.presentation.step_text += api.test_utils.format_step_text([
         ['failures:', failures]
@@ skipping 318 matching lines @@
   def run(self, api, suffix):
     api.chromium_android.coverage_report(upload=False)
     api.chromium_android.get_changed_lines_for_revision()
     api.chromium_android.incremental_coverage_report()
 
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]