Empty per_page_values shouldn't imply test success

scripts/slave/recipes/gpu/download_and_test.expected/linux_debug.json

 [
   {
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/cleanup_temp.py"
     ],
     "cwd": "[SLAVE_BUILD]",
     "name": "cleanup temp"
   },
@@ skipping 243 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "maps_pixel_test",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"

[Sergiy Byelozyorov, 2015/09/28 13:55:29]

I find it strange that we loose reported failures everywhere... shouldn't this
only affect tests that have non-zero return value? and even if we do not fail a
specific test, shouldn't we get a failure of the entire test suite.

[luqui, 2015/09/28 17:33:34]

This is due to the steps.py change, which changes the default for "Test1" from
failing to success.  We assume that it was default failing as a lazy way to get
coverage, but it's strange to have a test fail by default.

-    ]
+    "name": "maps_pixel_test"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 37 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "pixel_test",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "pixel_test"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "webgl_conformance_tests",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "webgl_conformance_tests"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "context_lost_tests",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "context_lost_tests"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "memory_test",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "memory_test"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "trace_test",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "trace_test"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "screenshot_sync_tests",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "screenshot_sync_tests"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "hardware_accelerated_feature_tests",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "hardware_accelerated_feature_tests"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 28 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "gpu_process_launch_tests",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "gpu_process_launch_tests"
   },
   {
     "allow_subannotations": true,
     "cmd": [
       "python",
       "-u",
       "[BUILD]/scripts/slave/runtest.py",
       "--target",
       "Debug",
       "--no-xvfb",
@@ skipping 32 matching lines @@
       "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
       "--output-format",
       "json",
       "--output-dir",
       "/path/to/tmp/"
     ],
     "cwd": "[SLAVE_BUILD]",
     "env": {
       "CHROME_DEVEL_SANDBOX": "/opt/chromium/chrome_sandbox"
     },
-    "name": "gpu_rasterization_tests",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@<br/>failures:<br/>Test.Test1<br/>@@@"
-    ]
+    "name": "gpu_rasterization_tests"
   }
 ]