Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1372693002: remove byte-accounting assert for crbug.com/536163 (Closed)

Created:
5 years, 2 months ago by ofrobots
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

remove byte-accounting assert for crbug.com/536163 The change https://codereview.chromium.org/1274453002 is causing a breakage on the Chrome OS builds. It is not clear how to easily revert because there is a following on dependent change (https://codereview.chromium.org/1351983002) am I am not too familiar with the revert process. The simplest revert is to remove the DCHECK. BUG=chromium:536163 LOG=n NOTRY=true R=machenbach@chromium.org, cmumford@chromium.org, hpayer@chromium.org Committed: https://crrev.com/1fe1c74a376d1d34b42d0b6489475e62468ee223 Cr-Commit-Position: refs/heads/master@{#30959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/incremental-marking.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
ofrobots
5 years, 2 months ago (2015-09-25 21:41:51 UTC) #1
Michael Achenbach
lgtm - to quick fix the roll. If there are other problems left, I'd just ...
5 years, 2 months ago (2015-09-27 20:31:33 UTC) #3
Michael Achenbach
I've added 'chromium:' prefix to bug number as otherwise, bugdroid won't make the connection.
5 years, 2 months ago (2015-09-27 20:32:31 UTC) #4
Michael Achenbach
I'll cq this in order to repair the roll asap.
5 years, 2 months ago (2015-09-28 05:39:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372693002/1
5 years, 2 months ago (2015-09-28 05:40:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6118)
5 years, 2 months ago (2015-09-28 05:43:27 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1fe1c74a376d1d34b42d0b6489475e62468ee223 Cr-Commit-Position: refs/heads/master@{#30959}
5 years, 2 months ago (2015-09-28 06:59:11 UTC) #12
Michael Achenbach
5 years, 2 months ago (2015-09-28 06:59:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fe1c74a376d1d34b42d0b6489475e62468ee223.

Powered by Google App Engine
This is Rietveld 408576698