Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: pkg/analyzer/lib/src/generated/error.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/error_verifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/error.dart
diff --git a/pkg/analyzer/lib/src/generated/error.dart b/pkg/analyzer/lib/src/generated/error.dart
index 84df1f97914ccf0b3227f71543759f5b5edfa097..4e56e1045172109bd3a0e593a9da8823246af6d1 100644
--- a/pkg/analyzer/lib/src/generated/error.dart
+++ b/pkg/analyzer/lib/src/generated/error.dart
@@ -2569,16 +2569,15 @@ class ErrorReporter {
* Report an error with the given [errorCode] and [arguments]. The [element]
* is used to compute the location of the error.
*/
- void reportErrorForElement(
- ErrorCode errorCode, Element element, List<Object> arguments) {
- String displayName = element.displayName;
+ void reportErrorForElement(ErrorCode errorCode, Element element,
+ [List<Object> arguments]) {
int length = 0;
- if (displayName != null) {
- length = displayName.length;
- } else if (element is ImportElement) {
+ if (element is ImportElement) {
length = 6; // 'import'.length
} else if (element is ExportElement) {
length = 6; // 'export'.length
+ } else {
+ length = element.nameLength;
}
reportErrorForOffset(errorCode, element.nameOffset, length, arguments);
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/error_verifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698