pkg/analysis_server/lib/src/services/refactoring/rename_import.dart - Issue 1372673003: Use Element.nameLength where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/index/indexable_element.dart ('k') | pkg/analysis_server/test/services/index/dart_index_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

index 6b73dd9533bac5ec4ee6f4338544bf26da608c06..4dcd752f7508c5143924de3d509a202df6b09fae 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

@@ -54,7 +54,7 @@ class RenameImportRefactoringImpl extends RenameRefactoringImpl {

SourceEdit edit = null;

if (newName.isEmpty) {

int uriEnd = element.uriEnd;

- int prefixEnd = element.prefixOffset + prefix.displayName.length;

+ int prefixEnd = element.prefixOffset + prefix.nameLength;

SourceRange range = rangeStartEnd(uriEnd, prefixEnd);

edit = newSourceEdit_range(range, "");

} else {

@@ -63,7 +63,7 @@ class RenameImportRefactoringImpl extends RenameRefactoringImpl {

edit = newSourceEdit_range(range, " as ${newName}");

} else {

int offset = element.prefixOffset;

- int length = prefix.displayName.length;

+ int length = prefix.nameLength;

SourceRange range = rangeStartLength(offset, length);

edit = newSourceEdit_range(range, newName);

}