pkg/analysis_server/lib/src/protocol_server.dart - Issue 1372673003: Use Element.nameLength where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/protocol_server.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/protocol_server.dart

diff --git a/pkg/analysis_server/lib/src/protocol_server.dart b/pkg/analysis_server/lib/src/protocol_server.dart

index ff98970439143e62151445f9d891370bfa360e19..a9dd5dd9051d59bacb05d5d3339634c1cad7acd4 100644

--- a/pkg/analysis_server/lib/src/protocol_server.dart

+++ b/pkg/analysis_server/lib/src/protocol_server.dart

@@ -213,9 +213,8 @@ Location newLocation_fromElement(engine.Element element) {

if (context == null || source == null) {

return null;

}

- String name = element.displayName;

int offset = element.nameOffset;

- int length = name != null ? name.length : 0;

+ int length = element.nameLength;

if (element is engine.CompilationUnitElement) {

offset = 0;

length = 0;