pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart - Issue 1372673003: Use Element.nameLength where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart

diff --git a/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart b/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart

index ebefbfbaea9eff3497a8dd0798b529ee242189cb..2ede6f1c9419a9ef64e48c05835c24b9c9971cf6 100644

--- a/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart

+++ b/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart

@@ -27,7 +27,7 @@ class DartOccurrencesComputer implements OccurrencesContributor {

new _DartUnitOccurrencesComputerVisitor();

unit.accept(visitor);

visitor.elementsOffsets.forEach((engineElement, offsets) {

- int length = engineElement.displayName.length;

+ int length = engineElement.nameLength;

protocol.Element serverElement =

protocol.newElement_fromEngine(engineElement);

protocol.Occurrences occurrences =