Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: pkg/analysis_server/lib/src/services/index/index_contributor.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.src.index.index_contributor; 5 library services.src.index.index_contributor;
6 6
7 import 'dart:collection' show Queue; 7 import 'dart:collection' show Queue;
8 8
9 import 'package:analysis_server/analysis/index_core.dart'; 9 import 'package:analysis_server/analysis/index_core.dart';
10 import 'package:analysis_server/src/services/correction/namespace.dart'; 10 import 'package:analysis_server/src/services/correction/namespace.dart';
(...skipping 631 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 return false; 642 return false;
643 } 643 }
644 return target != null; 644 return target != null;
645 } 645 }
646 } 646 }
647 return false; 647 return false;
648 } 648 }
649 649
650 void _recordHasAncestor(ClassElement element) { 650 void _recordHasAncestor(ClassElement element) {
651 int offset = element.nameOffset; 651 int offset = element.nameOffset;
652 int length = element.name.length; 652 int length = element.nameLength;
653 LocationImpl location = _createLocationForOffset(offset, length); 653 LocationImpl location = _createLocationForOffset(offset, length);
654 _recordHasAncestor0(location, element, false, <ClassElement>[]); 654 _recordHasAncestor0(location, element, false, <ClassElement>[]);
655 } 655 }
656 656
657 void _recordHasAncestor0(LocationImpl location, ClassElement element, 657 void _recordHasAncestor0(LocationImpl location, ClassElement element,
658 bool includeThis, List<ClassElement> visitedElements) { 658 bool includeThis, List<ClassElement> visitedElements) {
659 if (element == null) { 659 if (element == null) {
660 return; 660 return;
661 } 661 }
662 if (visitedElements.contains(element)) { 662 if (visitedElements.contains(element)) {
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 } 810 }
811 811
812 /** 812 /**
813 * @return `true` if given "node" is part of [PrefixedIdentifier] "prefix.node ". 813 * @return `true` if given "node" is part of [PrefixedIdentifier] "prefix.node ".
814 */ 814 */
815 static bool _isIdentifierInPrefixedIdentifier(SimpleIdentifier node) { 815 static bool _isIdentifierInPrefixedIdentifier(SimpleIdentifier node) {
816 AstNode parent = node.parent; 816 AstNode parent = node.parent;
817 return parent is PrefixedIdentifier && parent.identifier == node; 817 return parent is PrefixedIdentifier && parent.identifier == node;
818 } 818 }
819 } 819 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698