Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1372653003: avx2 I422AlphaToARGB (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin, fbarchard
CC:
Dale Curtis
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

AVX2 1 step I422AlphaToARGB for gcc and win. C I420AlphaToARGB_Opt (5169 ms) SSSE3 I420AlphaToARGB_Opt (432 ms) AVX2 I420AlphaToARGB_Opt (358 ms) and with premultiplication as 2 step process: I420AlphaToARGB_Premult (7029 ms) I420AlphaToARGB_Premult (757 ms) I420AlphaToARGB_Premult (508 ms) R=harryjin@google.com BUG=libyuv:496, libyuv:473 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/9a0e12f5f19a6e24a79c03e523474098b698b172

Patch Set 1 #

Patch Set 2 : gcc version of I422Alpha #

Patch Set 3 : ABGR macro for store #

Patch Set 4 : GCC AVX2 use storeABGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -31 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 5 chunks +32 lines, -8 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/row_any.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M source/row_gcc.cc View 1 2 10 chunks +170 lines, -17 lines 0 comments Download
M source/row_win.cc View 1 6 chunks +105 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fbarchard1
5 years, 2 months ago (2015-09-25 18:52:12 UTC) #1
harryjin
lgtm
5 years, 2 months ago (2015-09-25 20:25:04 UTC) #2
fbarchard
With premultiplication, profile shows: 63.34% libyuv_unittest libyuv_unittest [.] I422AlphaToARGBRow_AVX2 33.69% libyuv_unittest libyuv_unittest [.] ARGBAttenuateRow_AVX2 Speed ...
5 years, 2 months ago (2015-09-25 20:29:23 UTC) #4
fbarchard1
5 years, 2 months ago (2015-09-25 20:37:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
9a0e12f5f19a6e24a79c03e523474098b698b172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698