cros: Update saml banner text and style.

cros: Update saml banner text and style.

BUG=337122
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247819

[xiyuan, 2014-01-29 01:27:50]

The flow change for http://crbug.com/330206 would take a bit longer. So let's
roll this trivial one in first.

Thanks.

[bartfab (slow), 2014-01-29 15:29:38]

lgtm

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right):

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.css:17: padding: 75px
0 0;
Nit: Would padding-top: 75px not be sufficient?

[xiyuan, 2014-01-29 16:12:34]

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right):

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.css:17: padding: 75px
0 0;
On 2014/01/29 15:29:38, bartfab wrote:
> Nit: Would padding-top: 75px not be sufficient?

The top padding is space for logo and saml notice banner. It should be enough
for one-line banner text.

[commit-bot: I haz the power, 2014-01-29 16:16:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/137263015/1

[bartfab (slow), 2014-01-29 16:30:17]

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right):

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.css:17: padding: 75px
0 0;
On 2014/01/29 16:12:34, xiyuan wrote:
> On 2014/01/29 15:29:38, bartfab wrote:
> > Nit: Would padding-top: 75px not be sufficient?
> 
> The top padding is space for logo and saml notice banner. It should be enough
> for one-line banner text.

What I meant was whether |padding-top: 75px| would not be a sufficient and
equivalent CSS statement for exactly the same thing as |padding: 75px 0 0|. I
find the former easier to parse than the latter. But it was an optional nit
anyway.

[xiyuan, 2014-01-29 16:32:09]

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right):

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.css:17: padding: 75px
0 0;
On 2014/01/29 16:30:17, bartfab wrote:
> On 2014/01/29 16:12:34, xiyuan wrote:
> > On 2014/01/29 15:29:38, bartfab wrote:
> > > Nit: Would padding-top: 75px not be sufficient?
> > 
> > The top padding is space for logo and saml notice banner. It should be
enough
> > for one-line banner text.
> 
> What I meant was whether |padding-top: 75px| would not be a sufficient and
> equivalent CSS statement for exactly the same thing as |padding: 75px 0 0|. I
> find the former easier to parse than the latter. But it was an optional nit
> anyway.

Oh, we need the '0 0' to override the non-saml #gaia-signin's style at line 8.

[commit-bot: I haz the power, 2014-01-30 03:37:00]

Change committed as 247819

[bartfab (slow), 2014-01-30 09:54:53]

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right):

https://codereview.chromium.org/137263015/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.css:17: padding: 75px
0 0;
On 2014/01/29 16:32:10, xiyuan wrote:
> On 2014/01/29 16:30:17, bartfab wrote:
> > On 2014/01/29 16:12:34, xiyuan wrote:
> > > On 2014/01/29 15:29:38, bartfab wrote:
> > > > Nit: Would padding-top: 75px not be sufficient?
> > > 
> > > The top padding is space for logo and saml notice banner. It should be
> enough
> > > for one-line banner text.
> > 
> > What I meant was whether |padding-top: 75px| would not be a sufficient and
> > equivalent CSS statement for exactly the same thing as |padding: 75px 0 0|.
I
> > find the former easier to parse than the latter. But it was an optional nit
> > anyway.
> 
> Oh, we need the '0 0' to override the non-saml #gaia-signin's style at line 8.

Ah, good to know. Thanks for clarifying.