Issue 137263009: change setAlphaType to not modify the pixelref's genID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137263009: change setAlphaType to not modify the pixelref's genID (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 10 months ago

Reviewers:
hal.canary, scroggo, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	include/core/SkBitmap.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	include/core/SkPixelRef.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

reed1

chrome calls setAlphaType (often) on immutable bitmaps, but all they are doing is marking it ...

6 years, 10 months ago (2014-01-28 15:56:14 UTC) #1

reed1

Committed patchset #1 manually as r13219 (presubmit successful).

6 years, 10 months ago (2014-01-28 16:05:45 UTC) #4

scroggo

6 years, 10 months ago (2014-01-28 18:58:08 UTC) #5

Message was sent while issue was closed.

On 2014/01/28 16:05:45, reed1 wrote:
> Committed patchset #1 manually as r13219 (presubmit successful).

lgtm