chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm - Issue 137263007: Move CancelableTaskTracker to //base/task/CancelableTaskTracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm

Issue 137263007: Move CancelableTaskTracker to //base/task/CancelableTaskTracker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move to base/task/cancelable_task_tracker* Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm b/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm

index 2e8c9d2661572bc2b5ae5c03a9fc04571b6bb420..e226f259680980a712197d6ae06f2abec48315e5 100644

--- a/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm

+++ b/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm

@@ -338,7 +338,7 @@ TEST_F(HistoryMenuBridgeTest, GetFaviconForHistoryItem) {

// Make sure the item was modified properly.

EXPECT_TRUE(item.icon_requested);

- EXPECT_NE(CancelableTaskTracker::kBadTaskId, item.icon_task_id);

+ EXPECT_NE(base::CancelableTaskTracker::kBadTaskId, item.icon_task_id);

}

TEST_F(HistoryMenuBridgeTest, GotFaviconData) {

« no previous file with comments | « chrome/browser/ui/cocoa/history_menu_bridge.mm ('k') | chrome/browser/ui/gtk/download/download_item_gtk.h » ('j') | no next file with comments »