Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: chrome/browser/chromeos/version_loader.h

Issue 137263007: Move CancelableTaskTracker to //base/task/CancelableTaskTracker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to base/task/cancelable_task_tracker* Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/system/syslogs_provider.cc ('k') | chrome/browser/chromeos/version_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/version_loader.h
diff --git a/chrome/browser/chromeos/version_loader.h b/chrome/browser/chromeos/version_loader.h
index 6361bcb4ac796bc1d3801f2260ea25dc1932262e..de6e5f9dd4917e1599e17a6919c96b8d62ebe9b0 100644
--- a/chrome/browser/chromeos/version_loader.h
+++ b/chrome/browser/chromeos/version_loader.h
@@ -9,7 +9,7 @@
#include "base/callback.h"
#include "base/gtest_prod_util.h"
-#include "chrome/common/cancelable_task_tracker.h"
+#include "base/task/cancelable_task_tracker.h"
namespace chromeos {
@@ -20,7 +20,7 @@ namespace chromeos {
// To use ChromeOSVersionLoader do the following:
//
// . In your class define a member field of type chromeos::VersionLoader and
-// CancelableTaskTracker.
+// base::CancelableTaskTracker.
// . Define the callback method, something like:
// void OnGetChromeOSVersion(const std::string& version);
// . When you want the version invoke:
@@ -46,12 +46,14 @@ class VersionLoader {
// Asynchronously requests the version.
// If |full_version| is true version string with extra info is extracted,
// otherwise it's in short format x.x.xx.x.
- CancelableTaskTracker::TaskId GetVersion(VersionFormat format,
- const GetVersionCallback& callback,
- CancelableTaskTracker* tracker);
-
- CancelableTaskTracker::TaskId GetFirmware(const GetFirmwareCallback& callback,
- CancelableTaskTracker* tracker);
+ base::CancelableTaskTracker::TaskId GetVersion(
+ VersionFormat format,
+ const GetVersionCallback& callback,
+ base::CancelableTaskTracker* tracker);
+
+ base::CancelableTaskTracker::TaskId GetFirmware(
+ const GetFirmwareCallback& callback,
+ base::CancelableTaskTracker* tracker);
private:
FRIEND_TEST_ALL_PREFIXES(VersionLoaderTest, ParseFirmware);
« no previous file with comments | « chrome/browser/chromeos/system/syslogs_provider.cc ('k') | chrome/browser/chromeos/version_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698