Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: base/task/cancelable_task_tracker.cc

Issue 137263007: Move CancelableTaskTracker to //base/task/CancelableTaskTracker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to base/task/cancelable_task_tracker* Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task/cancelable_task_tracker.h ('k') | base/task/cancelable_task_tracker_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/cancelable_task_tracker.h" 5 #include "base/task/cancelable_task_tracker.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/location.h" 12 #include "base/location.h"
13 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
14 #include "base/message_loop/message_loop_proxy.h" 14 #include "base/message_loop/message_loop_proxy.h"
15 #include "base/synchronization/cancellation_flag.h" 15 #include "base/synchronization/cancellation_flag.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 void RunOrPostToTaskRunner(TaskRunner* task_runner, const Closure& closure) { 48 void RunOrPostToTaskRunner(TaskRunner* task_runner, const Closure& closure) {
49 if (task_runner->RunsTasksOnCurrentThread()) 49 if (task_runner->RunsTasksOnCurrentThread())
50 closure.Run(); 50 closure.Run();
51 else 51 else
52 task_runner->PostTask(FROM_HERE, closure); 52 task_runner->PostTask(FROM_HERE, closure);
53 } 53 }
54 54
55 } // namespace 55 } // namespace
56 56
57 namespace base {
58
57 // static 59 // static
58 const CancelableTaskTracker::TaskId CancelableTaskTracker::kBadTaskId = 0; 60 const CancelableTaskTracker::TaskId CancelableTaskTracker::kBadTaskId = 0;
59 61
60 CancelableTaskTracker::CancelableTaskTracker() 62 CancelableTaskTracker::CancelableTaskTracker()
61 : weak_factory_(this), 63 : weak_factory_(this), next_id_(1) {}
62 next_id_(1) {}
63 64
64 CancelableTaskTracker::~CancelableTaskTracker() { 65 CancelableTaskTracker::~CancelableTaskTracker() {
65 DCHECK(thread_checker_.CalledOnValidThread()); 66 DCHECK(thread_checker_.CalledOnValidThread());
66 67
67 TryCancelAll(); 68 TryCancelAll();
68 } 69 }
69 70
70 CancelableTaskTracker::TaskId CancelableTaskTracker::PostTask( 71 CancelableTaskTracker::TaskId CancelableTaskTracker::PostTask(
71 TaskRunner* task_runner, 72 TaskRunner* task_runner,
72 const tracked_objects::Location& from_here, 73 const tracked_objects::Location& from_here,
(...skipping 12 matching lines...) Expand all
85 86
86 // We need a MessageLoop to run reply. 87 // We need a MessageLoop to run reply.
87 DCHECK(base::MessageLoopProxy::current().get()); 88 DCHECK(base::MessageLoopProxy::current().get());
88 89
89 // Owned by reply callback below. 90 // Owned by reply callback below.
90 CancellationFlag* flag = new CancellationFlag(); 91 CancellationFlag* flag = new CancellationFlag();
91 92
92 TaskId id = next_id_; 93 TaskId id = next_id_;
93 next_id_++; // int64 is big enough that we ignore the potential overflow. 94 next_id_++; // int64 is big enough that we ignore the potential overflow.
94 95
95 const Closure& untrack_closure = Bind( 96 const Closure& untrack_closure =
96 &CancelableTaskTracker::Untrack, weak_factory_.GetWeakPtr(), id); 97 Bind(&CancelableTaskTracker::Untrack, weak_factory_.GetWeakPtr(), id);
97 bool success = task_runner->PostTaskAndReply( 98 bool success =
98 from_here, 99 task_runner->PostTaskAndReply(from_here,
99 Bind(&RunIfNotCanceled, flag, task), 100 Bind(&RunIfNotCanceled, flag, task),
100 Bind(&RunIfNotCanceledThenUntrack, 101 Bind(&RunIfNotCanceledThenUntrack,
101 base::Owned(flag), reply, untrack_closure)); 102 base::Owned(flag),
103 reply,
104 untrack_closure));
102 105
103 if (!success) 106 if (!success)
104 return kBadTaskId; 107 return kBadTaskId;
105 108
106 Track(id, flag); 109 Track(id, flag);
107 return id; 110 return id;
108 } 111 }
109 112
110 CancelableTaskTracker::TaskId CancelableTaskTracker::NewTrackedTaskId( 113 CancelableTaskTracker::TaskId CancelableTaskTracker::NewTrackedTaskId(
111 IsCanceledCallback* is_canceled_cb) { 114 IsCanceledCallback* is_canceled_cb) {
112 DCHECK(thread_checker_.CalledOnValidThread()); 115 DCHECK(thread_checker_.CalledOnValidThread());
113 DCHECK(base::MessageLoopProxy::current().get()); 116 DCHECK(base::MessageLoopProxy::current().get());
114 117
115 TaskId id = next_id_; 118 TaskId id = next_id_;
116 next_id_++; // int64 is big enough that we ignore the potential overflow. 119 next_id_++; // int64 is big enough that we ignore the potential overflow.
117 120
118 // Will be deleted by |untrack_and_delete_flag| after Untrack(). 121 // Will be deleted by |untrack_and_delete_flag| after Untrack().
119 CancellationFlag* flag = new CancellationFlag(); 122 CancellationFlag* flag = new CancellationFlag();
120 123
121 Closure untrack_and_delete_flag = Bind( 124 Closure untrack_and_delete_flag = Bind(
122 &RunAndDeleteFlag, 125 &RunAndDeleteFlag,
123 Bind(&CancelableTaskTracker::Untrack, weak_factory_.GetWeakPtr(), id), 126 Bind(&CancelableTaskTracker::Untrack, weak_factory_.GetWeakPtr(), id),
124 flag); 127 flag);
125 128
126 // Will always run |untrack_and_delete_flag| on current MessageLoop. 129 // Will always run |untrack_and_delete_flag| on current MessageLoop.
127 base::ScopedClosureRunner* untrack_and_delete_flag_runner = 130 base::ScopedClosureRunner* untrack_and_delete_flag_runner =
128 new base::ScopedClosureRunner( 131 new base::ScopedClosureRunner(Bind(&RunOrPostToTaskRunner,
129 Bind(&RunOrPostToTaskRunner, 132 base::MessageLoopProxy::current(),
130 base::MessageLoopProxy::current(), 133 untrack_and_delete_flag));
131 untrack_and_delete_flag));
132 134
133 *is_canceled_cb = Bind( 135 *is_canceled_cb =
134 &IsCanceled, flag, base::Owned(untrack_and_delete_flag_runner)); 136 Bind(&IsCanceled, flag, base::Owned(untrack_and_delete_flag_runner));
135 137
136 Track(id, flag); 138 Track(id, flag);
137 return id; 139 return id;
138 } 140 }
139 141
140 void CancelableTaskTracker::TryCancel(TaskId id) { 142 void CancelableTaskTracker::TryCancel(TaskId id) {
141 DCHECK(thread_checker_.CalledOnValidThread()); 143 DCHECK(thread_checker_.CalledOnValidThread());
142 144
143 hash_map<TaskId, CancellationFlag*>::const_iterator it = task_flags_.find(id); 145 hash_map<TaskId, CancellationFlag*>::const_iterator it = task_flags_.find(id);
144 if (it == task_flags_.end()) { 146 if (it == task_flags_.end()) {
(...skipping 29 matching lines...) Expand all
174 176
175 bool success = task_flags_.insert(std::make_pair(id, flag)).second; 177 bool success = task_flags_.insert(std::make_pair(id, flag)).second;
176 DCHECK(success); 178 DCHECK(success);
177 } 179 }
178 180
179 void CancelableTaskTracker::Untrack(TaskId id) { 181 void CancelableTaskTracker::Untrack(TaskId id) {
180 DCHECK(thread_checker_.CalledOnValidThread()); 182 DCHECK(thread_checker_.CalledOnValidThread());
181 size_t num = task_flags_.erase(id); 183 size_t num = task_flags_.erase(id);
182 DCHECK_EQ(1u, num); 184 DCHECK_EQ(1u, num);
183 } 185 }
186
187 } // namespace base
OLDNEW
« no previous file with comments | « base/task/cancelable_task_tracker.h ('k') | base/task/cancelable_task_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698