Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1372603002: [test] Skip test262-es6 tests failing on mac. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Skip test262-es6 tests failing on mac. Looks like we never ran test262-es6 on mac. After merging into test262 we've got these failures. Skipping for now. BUG=v8:4437 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Committed: https://crrev.com/689c117fc3abda38dbb081008eb49197e13e476c Cr-Commit-Position: refs/heads/master@{#30937}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M test/test262/test262.status View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Achenbach
TBR
5 years, 2 months ago (2015-09-25 13:39:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372603002/1
5 years, 2 months ago (2015-09-25 13:40:22 UTC) #4
Jakob Kummerow
LGTM with comment. Might also want to file a new bug for this, 4254 isn't ...
5 years, 2 months ago (2015-09-25 13:42:06 UTC) #6
Michael Achenbach
On 2015/09/25 13:42:06, Jakob wrote: > LGTM with comment. > > Might also want to ...
5 years, 2 months ago (2015-09-25 13:43:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372603002/20001
5 years, 2 months ago (2015-09-25 13:48:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372603002/20001
5 years, 2 months ago (2015-09-25 13:50:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 13:51:37 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 13:52:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/689c117fc3abda38dbb081008eb49197e13e476c
Cr-Commit-Position: refs/heads/master@{#30937}

Powered by Google App Engine
This is Rietveld 408576698