Added ActivityLog tests and associated bugfixes/extra logging.

chrome/browser/extensions/activity_log.cc

Index: chrome/browser/extensions/activity_log.cc
diff --git a/chrome/browser/extensions/activity_log.cc b/chrome/browser/extensions/activity_log.cc
index dcf8e8fdd5a54c209d08ffb0492afe6d4533c2bc..6a4e7055e7469f2cc5bcd30d862087524473ce1f 100644
--- a/chrome/browser/extensions/activity_log.cc
+++ b/chrome/browser/extensions/activity_log.cc
@@ -149,11 +149,10 @@ ActivityLog::ActivityLog(Profile* profile) {
       HasSwitch(switches::kEnableExtensionActivityUI);
 
   // enable-extension-activity-log-testing
-  // Currently, this just controls whether arguments are collected. In the
-  // future, it may also control other optional activity log features.
-  log_arguments_ = CommandLine::ForCurrentProcess()->
+  // This controls whether arguments are collected.
+  testing_mode_ = CommandLine::ForCurrentProcess()->

[palmer, 2013/04/11 21:53:39]

NIT: Fine by me, but some Chromies might want you to put |HasSwitch| on the same
line, then indent the argument by 4 spaces on the next line.

[felt, 2013/04/12 02:07:21]

Done.

       HasSwitch(switches::kEnableExtensionActivityLogTesting);
-  if (!log_arguments_) {
+  if (!testing_mode_) {
     for (int i = 0; i < APIAction::kSizeAlwaysLog; i++) {
       arg_whitelist_api_.insert(std::string(APIAction::kAlwaysLog[i]));
     }
@@ -244,7 +243,7 @@ void ActivityLog::LogAPIAction(const Extension* extension,
                                ListValue* args,
                                const std::string& extra) {
   if (!IsLogEnabled()) return;
-  if (!log_arguments_ &&
+  if (!testing_mode_ &&
       arg_whitelist_api_.find(api_call) == arg_whitelist_api_.end())
     args->Clear();
   LogAPIActionInternal(extension,
@@ -263,7 +262,7 @@ void ActivityLog::LogEventAction(const Extension* extension,
                                  ListValue* args,
                                  const std::string& extra) {
   if (!IsLogEnabled()) return;
-  if (!log_arguments_ &&
+  if (!testing_mode_ &&
       arg_whitelist_api_.find(api_call) == arg_whitelist_api_.end())
     args->Clear();
   LogAPIActionInternal(extension,
@@ -279,7 +278,7 @@ void ActivityLog::LogBlockedAction(const Extension* extension,
                                    const char* reason,
                                    const std::string& extra) {
   if (!IsLogEnabled()) return;
-  if (!log_arguments_ &&
+  if (!testing_mode_ &&
       arg_whitelist_api_.find(blocked_call) == arg_whitelist_api_.end())
     args->Clear();
   scoped_refptr<BlockedAction> action = new BlockedAction(extension->id(),