Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/renderer/extensions/api_activity_logger.h

Issue 13726026: Added ActivityLog tests and associated bugfixes/extra logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted two changes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/api_activity_logger.h
diff --git a/chrome/renderer/extensions/api_activity_logger.h b/chrome/renderer/extensions/api_activity_logger.h
index a2a0fd37fae9383a84b75e3dfd3be27e6d3ad8c3..75ecfe9373f6ed28f75bbe26dbfda15ca145ccf0 100644
--- a/chrome/renderer/extensions/api_activity_logger.h
+++ b/chrome/renderer/extensions/api_activity_logger.h
@@ -20,11 +20,13 @@ class APIActivityLogger : public ChromeV8Extension {
APIActivityLogger(Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context);
// This is ultimately invoked in schema_generated_bindings.js with
- // JavaScript arguments...
- // arg0 - extension ID as a string
- // arg1 - API call name as a string
- // arg2 - arguments to the API call
- // arg3 - any extra logging info as a string (optional)
+ // JavaScript arguments. Logged as an EventAction or APIAction depending on
+ // the first argument.
+ // arg0 - "EVENT" or "API"
+ // arg1 - extension ID as a string
+ // arg2 - API call name as a string
+ // arg3 - arguments to the API call
+ // arg4 - any extra logging info as a string (optional)
static v8::Handle<v8::Value> LogActivity(const v8::Arguments & args);
private:

Powered by Google App Engine
This is Rietveld 408576698