Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: chrome/renderer/resources/extensions/miscellaneous_bindings.js

Issue 13726026: Added ActivityLog tests and associated bugfixes/extra logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added message passing test and logging Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/miscellaneous_bindings.js
diff --git a/chrome/renderer/resources/extensions/miscellaneous_bindings.js b/chrome/renderer/resources/extensions/miscellaneous_bindings.js
index 78bed08310da0b160c95f052ab8c538f815041dd..fc8402003304c7f2ab1a7e4b9800c52f619c0a8e 100644
--- a/chrome/renderer/resources/extensions/miscellaneous_bindings.js
+++ b/chrome/renderer/resources/extensions/miscellaneous_bindings.js
@@ -24,6 +24,8 @@
var manifestVersion = processNatives.GetManifestVersion();
var extensionId = processNatives.GetExtensionId();
+ var logActivity = requireNative('activityLogger').LogActivity;
+
// The reserved channel name for the sendRequest/sendMessage APIs.
// Note: sendRequest is deprecated.
chromeHidden.kRequestChannel = "chrome.extension.sendRequest";
@@ -175,6 +177,12 @@
}
}
});
+ var eventName = (isSendMessage ?
Matt Perry 2013/04/09 20:56:59 you can use requestEvent_.eventName_
felt 2013/04/10 00:21:38 Done.
felt 2013/04/10 22:25:04 I reverted this change -- eventName_ is there, but
Matt Perry 2013/04/10 22:48:06 Doh, sorry about that.
+ (isExternal ?
+ "runtime.onMessageExternal" : "runtime.onMessage") :
+ (isExternal ?
+ "extension.onRequestExternal" : "extension.onRequest"));
+ logActivity("EVENT", targetExtensionId, eventName, [sourceExtensionId]);
return true;
}
return false;
@@ -218,6 +226,9 @@
port.tab = port.sender.tab;
connectEvent.dispatch(port);
+ var eventName = (isExternal ?
+ "runtime.onConnectExternal" : "runtime.onConnect");
Matt Perry 2013/04/09 20:56:59 same here, with connectEvent
felt 2013/04/10 00:21:38 Done.
+ logActivity("EVENT", targetExtensionId, eventName, [sourceExtensionId]);
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698