Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5357)

Unified Diff: chrome/browser/extensions/event_router.cc

Issue 13726026: Added ActivityLog tests and associated bugfixes/extra logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added message passing test and logging Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/event_router.cc
diff --git a/chrome/browser/extensions/event_router.cc b/chrome/browser/extensions/event_router.cc
index 4a75636f9fd65c20d207b35fc239af8a79425825..818dbadb8cf5faae15574728c7e119555db1b22f 100644
--- a/chrome/browser/extensions/event_router.cc
+++ b/chrome/browser/extensions/event_router.cc
@@ -236,6 +236,10 @@ void EventRouter::OnListenerAdded(const EventListener* listener) {
if (observer != observers_.end())
observer->second->OnListenerAdded(details);
+#if 0
+ // TODO(felt): Experimentally determine if these are needed, or if they
+ // can be permanently removed. Temporarily removing for now to reduce log
+ // size while under investigation.
const Extension* extension = extensions::ExtensionSystem::Get(profile_)->
extension_service()->GetExtensionById(listener->extension_id,
ExtensionService::INCLUDE_ENABLED);
@@ -248,6 +252,7 @@ void EventRouter::OnListenerAdded(const EventListener* listener) {
args.get(),
"");
}
+#endif
}
void EventRouter::OnListenerRemoved(const EventListener* listener) {
@@ -265,7 +270,10 @@ void EventRouter::OnListenerRemoved(const EventListener* listener) {
BrowserThread::IO, FROM_HERE,
base::Bind(&NotifyEventListenerRemovedOnIOThread,
profile, listener->extension_id, event_name));
-
+#if 0
+ // TODO(felt): Experimentally determine if these are needed, or if they
+ // can be permanently removed. Temporarily removing for now to reduce log
+ // size while under investigation.
const Extension* extension = extensions::ExtensionSystem::Get(profile_)->
extension_service()->GetExtensionById(listener->extension_id,
ExtensionService::INCLUDE_ENABLED);
@@ -276,6 +284,7 @@ void EventRouter::OnListenerRemoved(const EventListener* listener) {
args.get(),
"");
}
+#endif
}
void EventRouter::AddLazyEventListener(const std::string& event_name,

Powered by Google App Engine
This is Rietveld 408576698