Added ActivityLog tests and associated bugfixes/extra logging.

chrome/browser/extensions/event_router.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/event_router.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 218 matching lines @@
     observers_.erase(iters_to_remove[i]);
 }
 
 void EventRouter::OnListenerAdded(const EventListener* listener) {
   const std::string& event_name = listener->event_name;
   const EventListenerInfo details(event_name, listener->extension_id);
   ObserverMap::iterator observer = observers_.find(event_name);
   if (observer != observers_.end())
     observer->second->OnListenerAdded(details);
 
+#if 0
+  // TODO(felt): Experimentally determine if these are needed, or if they
+  // can be permanently removed. Temporarily removing for now to reduce log
+  // size while under investigation.
   const Extension* extension = extensions::ExtensionSystem::Get(profile_)->
       extension_service()->GetExtensionById(listener->extension_id,
                                             ExtensionService::INCLUDE_ENABLED);
   if (extension) {
     scoped_ptr<ListValue> args(new ListValue());
     if (listener->filter)
       args->Append(listener->filter->DeepCopy());
     activity_log_->LogAPIAction(extension,
                                 event_name + ".addListener",
                                 args.get(),
                                 "");
   }
+#endif
 }
 
 void EventRouter::OnListenerRemoved(const EventListener* listener) {
   const std::string& event_name = listener->event_name;
   const EventListenerInfo details(event_name, listener->extension_id);
   ObserverMap::iterator observer = observers_.find(event_name);
   if (observer != observers_.end())
     observer->second->OnListenerRemoved(details);
 
   void* profile =
       listener->process
           ? Profile::FromBrowserContext(listener->process->GetBrowserContext())
           : NULL;
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&NotifyEventListenerRemovedOnIOThread,
                  profile, listener->extension_id, event_name));
-
+#if 0
+  // TODO(felt): Experimentally determine if these are needed, or if they
+  // can be permanently removed. Temporarily removing for now to reduce log
+  // size while under investigation.
   const Extension* extension = extensions::ExtensionSystem::Get(profile_)->
       extension_service()->GetExtensionById(listener->extension_id,
                                             ExtensionService::INCLUDE_ENABLED);
   if (extension) {
     scoped_ptr<ListValue> args(new ListValue());
     activity_log_->LogAPIAction(extension,
                                 event_name + ".removeListener",
                                 args.get(),
                                 "");
   }
+#endif
 }
 
 void EventRouter::AddLazyEventListener(const std::string& event_name,
                                        const std::string& extension_id) {
   scoped_ptr<EventListener> listener(new EventListener(
       event_name, extension_id, NULL, scoped_ptr<DictionaryValue>()));
   bool is_new = listeners_.AddListener(listener.Pass());
 
   if (is_new) {
     ExtensionPrefs* prefs = extensions::ExtensionSystem::Get(profile_)->
@@ skipping 431 matching lines @@
   copy->will_dispatch_callback = will_dispatch_callback;
   return copy;
 }
 
 EventListenerInfo::EventListenerInfo(const std::string& event_name,
                                      const std::string& extension_id)
     : event_name(event_name),
       extension_id(extension_id) {}
 
 }  // namespace extensions