Added ActivityLog tests and associated bugfixes/extra logging.

chrome/renderer/resources/extensions/binding.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 require('json_schema');
 require('event_bindings');
 var chrome = requireNative('chrome').GetChrome();
 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
 var forEach = require('utils').forEach;
 var GetAvailability = requireNative('v8_context').GetAvailability;
@@ skipping 35 matching lines @@
   if (this.unavailableApiFunctions_.hasOwnProperty(apiName))
     return;
   if (!this.apiFunctions_.hasOwnProperty(apiName))
     throw new Error('Tried to set hook for unknown API "' + apiName + '"');
   this.apiFunctions_[apiName][propertyName] = customizedFunction;
 };
 
 APIFunctions.prototype.setHandleRequest =
     function(apiName, customizedFunction) {
   var prefix = this.namespace;
+  var slicer = Array.prototype.slice;

[Matt Perry, 2013/04/09 20:56:59]

why is this necessary?

[felt, 2013/04/10 22:25:04]

Removed for now.

   return this.setHook_(apiName, 'handleRequest',
     function() {
       var ret = customizedFunction.apply(this, arguments);
       // Logs API calls to the Activity Log if it doesn't go through an
       // ExtensionFunction.
       if (!sendRequestHandler.getCalledSendRequest())
-        logActivity(extensionId, prefix + "." + apiName,
-            Array.prototype.slice.call(arguments));
+        logActivity("API", extensionId, prefix + "." + apiName,
+            slicer.call(arguments));
       return ret;
     });
 };
 
 APIFunctions.prototype.setUpdateArgumentsPostValidate =
     function(apiName, customizedFunction) {
   return this.setHook_(
     apiName, 'updateArgumentsPostValidate', customizedFunction);
 };
 
@@ skipping 337 matching lines @@
       });
     };
 
     addProperties(mod, schema);
     this.runHooks_(mod);
     return mod;
   }
 };
 
 exports.Binding = Binding;