Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webkit/plugins/ppapi/plugin_delegate.h

Issue 13726024: Refactor FileSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/plugin_delegate.h
diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h
index 3a8a7248b175d79d316753f9eda714e7410a255b..9ff1fbae1533f569d8987e454a9694eb170b199f 100644
--- a/webkit/plugins/ppapi/plugin_delegate.h
+++ b/webkit/plugins/ppapi/plugin_delegate.h
@@ -24,6 +24,7 @@
#include "ppapi/c/dev/ppb_device_ref_dev.h"
#include "ppapi/c/pp_completion_callback.h"
#include "ppapi/c/pp_errors.h"
+#include "ppapi/c/pp_file_info.h"
#include "ppapi/c/pp_instance.h"
#include "ppapi/c/pp_resource.h"
#include "ppapi/c/pp_stdint.h"
@@ -464,6 +465,17 @@ class PluginDelegate {
int flags,
const AsyncOpenFileCallback& callback) = 0;
+ // These functions expose some of PepperFileSystemHost methods for
+ // PPB_FileRef_Impl (which is in webkit) to access. Once we migrate FileRef
+ // to the new design in content/, we won't need this delegation.
+ // TODO(victorhsieh): remove these delegation.
+ virtual bool IsFileSystemOpened(PP_Instance instance,
+ PP_Resource resource) const = 0;
+ virtual PP_FileSystemType GetFileSystemType(PP_Instance instance,
+ PP_Resource resource) const = 0;
+ virtual std::string GetFileSystemRootUrl(PP_Instance instance,
+ PP_Resource resource) const = 0;
+
// Sends an async IPC to open a file through filesystem API.
// When a file is successfully opened, |callback| is invoked with
// PLATFORM_FILE_OK, the opened file handle, and a callback function for
@@ -481,11 +493,6 @@ class PluginDelegate {
int flags,
const AsyncOpenFileSystemURLCallback& callback) = 0;
- virtual bool OpenFileSystem(
- const GURL& origin_url,
- fileapi::FileSystemType type,
- long long size,
- fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
virtual bool MakeDirectory(
const GURL& path,
bool recursive,

Powered by Google App Engine
This is Rietveld 408576698