Smart layer invalidation for LCD text.

skia/ext/analysis_canvas.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SKIA_EXT_ANALYSIS_CANVAS_H_
 #define SKIA_EXT_ANALYSIS_CANVAS_H_
 
 #include <list>
 #include <set>
 
@@ skipping 17 matching lines @@
   typedef std::list<skia::LazyPixelRef*> LazyPixelRefList;
 
   AnalysisCanvas(AnalysisDevice*);
   virtual ~AnalysisCanvas();
 
   // Returns true if the estimated cost of drawing is below an
   // arbitrary threshold.
   bool isCheap() const;
   bool getColorIfSolid(SkColor* color) const;
   bool isTransparent() const;
+  bool hasText() const;

[enne (OOO), 2013/04/05 21:39:36]

Is this file not in Chromium style?

[alokp, 2013/04/05 22:50:11]

We seem to be following skia style in this file.

[enne (OOO), 2013/04/05 22:58:12]

Except hasText_ is not Skia style?  At any rate, this whole file's style isn't
really in the scope of this patch to fix, but it's pretty confusing to review.

   void consumeLazyPixelRefs(LazyPixelRefList* pixelRefs);
 
   // Returns the estimated cost of drawing, in arbitrary units.
   int getEstimatedCost() const;
 
   virtual bool clipRect(const SkRect& rect,
                         SkRegion::Op op = SkRegion::kIntersect_Op,
                         bool doAntiAlias = false) OVERRIDE;
   virtual bool clipPath(const SkPath& path,
                         SkRegion::Op op = SkRegion::kIntersect_Op,
@@ skipping 21 matching lines @@
  public:
   typedef std::list<skia::LazyPixelRef*> LazyPixelRefList;
   typedef base::hash_set<uint32_t> IdSet;
 
   AnalysisDevice(const SkBitmap& bm);
   virtual ~AnalysisDevice();
 
   int getEstimatedCost() const;
   bool getColorIfSolid(SkColor* color) const;
   bool isTransparent() const;
+  bool hasText() const;
   void consumeLazyPixelRefs(LazyPixelRefList* pixelRefs);
 
   void setForceNotSolid(bool flag);
   void setForceNotTransparent(bool flag);
 
  protected:
   virtual void clear(SkColor color) OVERRIDE;
   virtual void drawPaint(const SkDraw&, const SkPaint& paint) OVERRIDE;
   virtual void drawPoints(const SkDraw&, SkCanvas::PointMode mode,
                           size_t count, const SkPoint[],
@@ skipping 48 matching lines @@
 
   void addPixelRefIfLazy(SkPixelRef* pixelRef);
   void addBitmap(const SkBitmap& bitmap);
   void addBitmapFromPaint(const SkPaint& paint);
 
   bool isForcedNotSolid_;
   bool isForcedNotTransparent_;
   bool isSolidColor_;
   SkColor color_;
   bool isTransparent_;
+  bool hasText_;
   IdSet existingPixelRefIDs_;
   LazyPixelRefList lazyPixelRefs_;
 };
 
 }  // namespace skia
 
 #endif  // SKIA_EXT_ANALYSIS_CANVAS_H_