Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: media/base/audio_bus.cc

Issue 13726011: Add vector_math::FMUL. Replace audio_util::AdjustVolume. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix NaCl. Add unittests. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_bus.cc
diff --git a/media/base/audio_bus.cc b/media/base/audio_bus.cc
index 0dc3300b8defc9e3964555df11d049e8892715ab..850ab3111a446954575c59729e1604b98aec8da3 100644
--- a/media/base/audio_bus.cc
+++ b/media/base/audio_bus.cc
@@ -9,6 +9,7 @@
#include "base/logging.h"
#include "media/audio/audio_parameters.h"
#include "media/base/limits.h"
+#include "media/base/vector_math.h"
namespace media {
@@ -307,4 +308,13 @@ void AudioBus::CopyTo(AudioBus* dest) const {
memcpy(dest->channel(i), channel(i), sizeof(*channel(i)) * frames());
}
+void AudioBus::AdjustVolume(float volume) {
+ if (volume > 0 && volume < 1) {
Chris Rogers 2013/04/05 21:31:35 I would suggest generalizing it by calling is Scal
DaleCurtis 2013/04/05 23:52:30 Lets see if we can get away with just the Scale()
+ for (int i = 0; i < channels(); ++i)
+ vector_math::FMUL(channel(i), volume, frames(), channel(i));
+ } else if (volume == 0) {
+ Zero();
+ }
+}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698