Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 13726009: MIPS: Force context allocation for variables in generator scopes. (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Force context allocation for variables in generator scopes. Port r14152 (4e58a8ea) Original commit message: * src/scopes.h (ForceContextAllocation, has_forced_context_allocation): New interface to force context allocation for an entire function's scope. * src/scopes.cc: Unless a new scope is a function scope, if its outer scope has forced context allocation, it should also force context allocation. (MustAllocateInContext): Return true if the scope as a whole has forced context allocation. (CollectStackAndContextLocals): Allow temporaries to be context-allocated. * src/parser.cc (ParseFunctionLiteral): Force context allocation for generator scopes. * src/v8globals.h (VariableMode): Update comment on TEMPORARY. * src/arm/full-codegen-arm.cc (Generate): * src/ia32/full-codegen-ia32.cc (Generate): * src/x64/full-codegen-x64.cc (Generate): Assert that generators have no stack slots. * test/mjsunit/harmony/generators-instantiation.js: New test. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/mips/full-codegen-mips.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 8 months ago (2013-04-05 16:33:00 UTC) #1
Michael Starzinger
LGTM.
7 years, 8 months ago (2013-04-05 16:34:30 UTC) #2
palfia
7 years, 8 months ago (2013-04-05 16:48:45 UTC) #3
Message was sent while issue was closed.
Committed manually as r14157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698