Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1372533002: [elements.cc] Clean up CopyDoubleToObjectElements (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements.cc] Clean up CopyDoubleToObjectElements Committed: https://crrev.com/2c705830843314e1619e277a957decc9f8b39853 Cr-Commit-Position: refs/heads/master@{#30935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M src/elements.cc View 3 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
PTAL.
5 years, 2 months ago (2015-09-25 11:30:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372533002/1
5 years, 2 months ago (2015-09-25 11:30:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-25 11:51:38 UTC) #6
Camillo Bruni
lgtm
5 years, 2 months ago (2015-09-25 12:21:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372533002/1
5 years, 2 months ago (2015-09-25 12:25:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 12:26:27 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 12:26:41 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2c705830843314e1619e277a957decc9f8b39853
Cr-Commit-Position: refs/heads/master@{#30935}

Powered by Google App Engine
This is Rietveld 408576698