[Font Load Events] Partial implementation of SetClass operations for FontFaceSet

[Font Load Events] Partial implementation of SetClass operations for FontFaceSet

This adds has() and forEach() methods and size attribute to FontFaceSet.
These are indicated by SetClass(FontFace) extended attribute of the
FontFaceSet interface[1]. The set interface should match the ES6 Set
objects[2].

This patch also makes FontFaceSet accesses CSSSegmentedFontFaceCache
directly; now CSSSegmentedFontFaceCache is a common backend for
CSSFontSelector and FontFaceSet.

[1] http://dev.w3.org/csswg/css-font-load-events/#FontFaceSet-interface
[2] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set-objects

BUG=53213
TEST=fast/css/fontfaceset-set-operations.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165185

[dglazkov, 2014-01-14 18:27:35]

lgtm fonty parts, but I think you need arv/haraken to look at the IDL things. I
am sort of surprised that SetClass() impl is just a bunch of custom code.

[arv (Not doing code reviews), 2014-01-14 19:45:19]

Not LGTM

The interface should match ES6

https://codereview.chromium.org/137253005/diff/1/Source/core/css/FontFaceSetF...
File Source/core/css/FontFaceSetForEachCallback.idl (right):

https://codereview.chromium.org/137253005/diff/1/Source/core/css/FontFaceSetF...
Source/core/css/FontFaceSetForEachCallback.idl:32: [CallWith=ThisValue] boolean
handleItem(FontFace fontFace, FontFaceSet set);
This needs to be

[CallWith=ThisValue] boolean handleItem(FontFace fontFace, FontFace fontFace,
FontFaceSet set);

Notice the duplication of the first param.

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set.prototype.foreach

[Kunihiko Sakamoto, 2014-01-15 01:42:02]

PTAL
Thanks for pointing it out. I didn't know ES6 defines the Set interface.

https://codereview.chromium.org/137253005/diff/1/Source/core/css/FontFaceSetF...
File Source/core/css/FontFaceSetForEachCallback.idl (right):

https://codereview.chromium.org/137253005/diff/1/Source/core/css/FontFaceSetF...
Source/core/css/FontFaceSetForEachCallback.idl:32: [CallWith=ThisValue] boolean
handleItem(FontFace fontFace, FontFaceSet set);
On 2014/01/14 19:45:20, arv wrote:
> This needs to be
> 
> [CallWith=ThisValue] boolean handleItem(FontFace fontFace, FontFace fontFace,
> FontFaceSet set);
> 
> Notice the duplication of the first param.
> 
>
https://people.mozilla.org/%7Ejorendorff/es6-draft.html#sec-set.prototype.for...

Done.

[arv (Not doing code reviews), 2014-01-15 15:23:07]

Thanks, LGTM

[commit-bot: I haz the power, 2014-01-16 00:58:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/137253005/120001

[commit-bot: I haz the power, 2014-01-16 02:40:44]

Change committed as 165185