Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 1372513003: [turbofan] Rename --context-specialization to --function-context-specialization. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rename --context-specialization to --function-context-specialization. This name makes it clear that the flag (also the variant in the Compiler) is talking about specializing to the function context instead of i.e. the native context. R=mstarzinger@chromium.org Committed: https://crrev.com/175edfb4701a63f3e4470363bd8b5d47f91488dc Cr-Commit-Position: refs/heads/master@{#30934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M src/compiler.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/compiler.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-4374.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-osr-context.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-09-25 10:42:55 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-09-25 10:43:35 UTC) #2
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-09-25 10:46:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372513003/1
5 years, 2 months ago (2015-09-25 10:47:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 11:33:32 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 11:33:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/175edfb4701a63f3e4470363bd8b5d47f91488dc
Cr-Commit-Position: refs/heads/master@{#30934}

Powered by Google App Engine
This is Rietveld 408576698