Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/events/CustomEvent.idl

Issue 1372513002: Store |detail| as a hidden value of custom event wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt ('K') | « third_party/WebKit/Source/core/events/CustomEvent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/CustomEvent.idl
diff --git a/third_party/WebKit/Source/core/events/CustomEvent.idl b/third_party/WebKit/Source/core/events/CustomEvent.idl
index 5e6d7abd36049c1f94cae0be83e1847462b91137..260e2e197a28cdad6adede21ca186c19e1b08b90 100644
--- a/third_party/WebKit/Source/core/events/CustomEvent.idl
+++ b/third_party/WebKit/Source/core/events/CustomEvent.idl
@@ -26,7 +26,9 @@
// https://dom.spec.whatwg.org/#interface-customevent
[
- Constructor(DOMString type, optional CustomEventInit eventInitDict),
+ // TODO(bashi): Don't use CustomConstructor. Constructor should be:
+ // Constructor(DOMString type, optional CustomEventInit eventInitDict),
+ CustomConstructor,
Exposed=(Window,Worker),
] interface CustomEvent : Event {
[Custom=Getter] readonly attribute any detail;
« third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt ('K') | « third_party/WebKit/Source/core/events/CustomEvent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698