third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt - Issue 1372513002: Store |detail| as a hidden value of custom event wrappers

Side by Side Diff: third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt

Issue 1372513002: Store |detail| as a hidden value of custom event wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/js/constructor-length.html ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 This tests the length property of constructors.	1 This tests the length property of constructors.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 PASS ArrayBuffer.length is 1	6 PASS ArrayBuffer.length is 1

7 PASS AudioContext.length is 0	7 PASS AudioContext.length is 0

8 PASS AutocompleteErrorEvent.length is 1	8 PASS AutocompleteErrorEvent.length is 1

9 PASS Blob.length is 0	9 PASS Blob.length is 0

10 PASS CloseEvent.length is 1	10 PASS CloseEvent.length is 1

11 PASS CustomEvent.length is 1	11 FAIL CustomEvent.length should be 1. Was 0.
	bashi 2015/09/29 00:07:10 Using custom constructor causes this regression. I Using custom constructor causes this regression. I think this is acceptable for a short-term workaround. WDYT? Or, we might want to make [CustomConstructor] have arguments like [Constructor] so that we can calculate \|length\|. I didn't take this approach because it would make this CL be difficult to merge branches. haraken 2015/09/29 00:18:52 constructor.length has been wrong for a long time Show quoted text On 2015/09/29 00:07:10, bashi1 wrote: > Using custom constructor causes this regression. I think this is acceptable for > a short-term workaround. WDYT? > > Or, we might want to make [CustomConstructor] have arguments like [Constructor] > so that we can calculate \|length\|. I didn't take this approach because it would > make this CL be difficult to merge branches. constructor.length has been wrong for a long time (maybe it's still wrong in some cases). So it would be reasonable to accept the regression in short term.
12 FAIL DOMFormData.length should be 0. Threw exception ReferenceError: DOMFormData is not defined	12 FAIL DOMFormData.length should be 0. Threw exception ReferenceError: DOMFormData is not defined

13 PASS DOMParser.length is 0	13 PASS DOMParser.length is 0

14 PASS DataView.length is 3	14 PASS DataView.length is 3

15 PASS ErrorEvent.length is 1	15 PASS ErrorEvent.length is 1

16 PASS Event.length is 1	16 PASS Event.length is 1

17 PASS EventSource.length is 1	17 PASS EventSource.length is 1

18 PASS Float32Array.length is 3	18 PASS Float32Array.length is 3

19 PASS Float64Array.length is 3	19 PASS Float64Array.length is 3

20 PASS FileReader.length is 0	20 PASS FileReader.length is 0

21 FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: FileRead erSync is not defined	21 FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: FileRead erSync is not defined

(...skipping 28 matching lines...) Expand all Loading...
50 PASS Worker.length is 1	50 PASS Worker.length is 1

51 PASS URL.length is 1	51 PASS URL.length is 1

52 PASS XMLHttpRequest.length is 0	52 PASS XMLHttpRequest.length is 0

53 PASS XMLSerializer.length is 0	53 PASS XMLSerializer.length is 0

54 PASS XPathEvaluator.length is 0	54 PASS XPathEvaluator.length is 0

55 PASS XSLTProcessor.length is 0	55 PASS XSLTProcessor.length is 0

56 PASS successfullyParsed is true	56 PASS successfullyParsed is true

57	57

58 TEST COMPLETE	58 TEST COMPLETE

59	59

OLD	NEW