Store |detail| as a hidden value of custom event wrappers

third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "bindings/core/v8/V8CustomEvent.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/V8CustomEventInit.h"
 #include "bindings/core/v8/V8DOMWrapper.h"
 #include "bindings/core/v8/V8Event.h"
 #include "bindings/core/v8/V8HiddenValue.h"
 #include "core/dom/ContextFeatures.h"
 #include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 static v8::Local<v8::Value> cacheState(v8::Isolate* isolate, v8::Local<v8::Object> customEvent, v8::Local<v8::Value> detail)
 {
     V8HiddenValue::setHiddenValue(isolate, customEvent, V8HiddenValue::detail(isolate), detail);
     return detail;
 }
 
+void V8CustomEvent::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomEvent", info.Holder(), info.GetIsolate());
+    if (UNLIKELY(info.Length() < 1)) {
+        setMinimumArityTypeError(exceptionState, 1, info.Length());
+        exceptionState.throwIfNeeded();
+        return;
+    }
+
+    V8StringResource<> type = info[0];
+    if (!type.prepare())
+        return;
+
+    CustomEventInit eventInitDict;
+    if (!isUndefinedOrNull(info[1])) {
+        if (!info[1]->IsObject()) {
+            exceptionState.throwTypeError("parameter 2 ('eventInitDict') is not an object.");
+            exceptionState.throwIfNeeded();
+            return;
+        }
+        V8CustomEventInit::toImpl(info.GetIsolate(), info[1], eventInitDict, exceptionState);
+        if (exceptionState.throwIfNeeded())
+            return;
+    }
+
+    RefPtrWillBeRawPtr<CustomEvent> impl = CustomEvent::create(type, eventInitDict);
+    v8::Local<v8::Object> wrapper = info.Holder();
+    wrapper = impl->associateWithWrapper(info.GetIsolate(), &V8CustomEvent::wrapperTypeInfo, wrapper);
+
+    // TODO(bashi): Workaround for http://crbug.com/529941. We need to store
+    // |detail| as a hidden value to avoid cycle references.
+    if (eventInitDict.hasDetail()) {
+        v8::Local<v8::Value> v8Detail = eventInitDict.detail().v8Value();
+        cacheState(info.GetIsolate(), wrapper, v8Detail);
+        // When a custom event is created in an isolated world, serialize
+        // |detail| and store it in |impl| so that we can clone |detail|
+        // when the getter of |detail| is called in the main world later.
+        if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld())
+            impl->setSerializedDetail(SerializedScriptValueFactory::instance().createAndSwallowExceptions(info.GetIsolate(), v8Detail));
+    }

[haraken, 2015/09/25 10:08:10]

Just to confirm: The line 82 - 92 is the only difference between auto-generated
constructor and the custom constructor, right?

[bashi, 2015/09/28 05:22:57]

Yes.

+    wrapper = impl->associateWithWrapper(info.GetIsolate(), &V8CustomEvent::wrapperTypeInfo, wrapper);

[haraken, 2015/09/25 10:08:10]

Remove this. You already execute this at line 80.

[bashi, 2015/09/28 05:22:57]

Done.

+    v8SetReturnValue(info, wrapper);
+}
 
 void V8CustomEvent::detailAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     CustomEvent* event = V8CustomEvent::toImpl(info.Holder());
 
     v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::detail(info.GetIsolate()));
 
     if (!result.IsEmpty()) {
         v8SetReturnValue(info, result);
         return;
     }
 
     // Be careful not to return a V8 value which is created in different world.
     v8::Local<v8::Value> detail;
-    if (SerializedScriptValue* serializedValue = event->serializedDetail())
+    if (SerializedScriptValue* serializedValue = event->serializedDetail()) {
         detail = serializedValue->deserialize();
-    else
-        detail = event->detail().v8ValueFor(ScriptState::current(info.GetIsolate()));
+    } else if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld()) {
+        v8::Local<v8::Value> mainWorldDetail = V8HiddenValue::getHiddenValueFromMainWorldWrapper(info.GetIsolate(), event, V8HiddenValue::detail(info.GetIsolate()));
+        if (!mainWorldDetail.IsEmpty())
+            detail = SerializedScriptValueFactory::instance().createAndSwallowExceptions(info.GetIsolate(), mainWorldDetail)->deserialize();

[haraken, 2015/09/25 10:08:10]

At this point, wouldn't it be better to cache the serialized detail object onto
CustomEvent::m_serializedDetail?

[bashi, 2015/09/28 05:22:57]

Right. I overlooked that there could be more than one isolated worlds. Done.

+    }
+
     // |detail| should be null when it is an empty handle because its default value is null.
     if (detail.IsEmpty())
         detail = v8::Null(info.GetIsolate());
     v8SetReturnValue(info, cacheState(info.GetIsolate(), info.Holder(), detail));
 }
 
 } // namespace blink