Aura: Make views_unittests work with --ui-enable-threaded-compositing

Aura: Make views_unittests work with --ui-enable-threaded-compositing

BUG=173417
TEST=views_unittests --ui-enable-threaded-compositing

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192871

[jonathan.backer, 2013-04-05 19:08:24]

Based off of https://codereview.chromium.org/13555004/

[piman, 2013-04-05 19:28:49]

https://codereview.chromium.org/13725019/diff/1/ui/compositor/compositor.h
File ui/compositor/compositor.h (right):

https://codereview.chromium.org/13725019/diff/1/ui/compositor/compositor.h#ne...
ui/compositor/compositor.h:335: friend class DrawWaiter;
I don't think DrawWaiter needs intimate knowledge of the compositor.

How about moving DrawWaiter to be more public, and moving the timeout value
there, and then providing maybe a helper static
DrawWaiter::Wait(ui::Compositor*) ?

That way, we don't need the layering violating friend declaration.

If we're worried about misuse outside of tests, we can name it DrawWaiterForTest
(and/or moving it to test infrastructure).

[jonathan.backer, 2013-04-05 20:08:04]

https://codereview.chromium.org/13725019/diff/1/ui/compositor/compositor.h
File ui/compositor/compositor.h (right):

https://codereview.chromium.org/13725019/diff/1/ui/compositor/compositor.h#ne...
ui/compositor/compositor.h:335: friend class DrawWaiter;
On 2013/04/05 19:28:49, piman wrote:
> I don't think DrawWaiter needs intimate knowledge of the compositor.
> 
> How about moving DrawWaiter to be more public, and moving the timeout value
> there, and then providing maybe a helper static
> DrawWaiter::Wait(ui::Compositor*) ?
> 
> That way, we don't need the layering violating friend declaration.
> 
> If we're worried about misuse outside of tests, we can name it
DrawWaiterForTest
> (and/or moving it to test infrastructure).

Done.

I think it's much cleaner now. Thanks.

[piman, 2013-04-05 20:14:29]

LGTM, thanks!

[jonathan.backer, 2013-04-05 20:17:43]

+sky for ui/views/view_unittest.cc OWNERS

[sky, 2013-04-05 21:11:47]

LGTM

[commit-bot: I haz the power, 2013-04-06 00:16:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/backer@chromium.org/13725019/3005

[commit-bot: I haz the power, 2013-04-06 00:33:32]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 13:21:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/backer@chromium.org/13725019/15001

[commit-bot: I haz the power, 2013-04-08 13:28:59]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 19:52:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/backer@chromium.org/13725019/15001

[commit-bot: I haz the power, 2013-04-08 20:11:18]

Change committed as 192871