about:net-internals: Add support for negative text filters

about:net-internals:  Add support for negative text filters,
and update the mouseover help.

BUG=116601
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194731

[mmenke, 2013-04-17 19:04:49]

No rush on this one.  For source_filter_parser.js, may get some limited mileage
out of comparing with set 1, which has the old filter parsing code copied into
the new file.

The use of function composition is primarily motivated by the desire not to have
two different chunks of code know about each filter.  Set 2 has the non-filter
composition version, if you think that's the better approach.

I've switched to using "-" as a prefix fort sort/types for consistency, though
not sure if that's a good idea - if we ever take a list of sort orders, could
see wanting sort:-type,desc,-id.

[eroman, 2013-04-17 21:38:05]

lgtm

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
File chrome/browser/resources/net_internals/source_filter_parser.js (right):

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
chrome/browser/resources/net_internals/source_filter_parser.js:19: // Text
filters are stored here a strings, and then added as a function on
"here a strings" --> "here as strings"

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
chrome/browser/resources/net_internals/source_filter_parser.js:20: // the end,
for performance reason.
"for performance reason" --> "for performance reasons".

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
File chrome/browser/resources/net_internals/source_row.js (right):

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
chrome/browser/resources/net_internals/source_row.js:168: matchesFilter:
function(filter) {
Actually I think this is only used in one place -- perhaps can just delete this
function and have caller directly call filter.

https://codereview.chromium.org/13725016/diff/45001/chrome/test/data/webui/ne...
File chrome/test/data/webui/net_internals/events_view.js (right):

https://codereview.chromium.org/13725016/diff/45001/chrome/test/data/webui/ne...
chrome/test/data/webui/net_internals/events_view.js:187: { text: '-sort:"shoe
size"', matches: [true, true] },
I hope this is a pony horse shoe...

[mmenke, 2013-04-17 22:34:55]

Thanks for the feedback!

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
File chrome/browser/resources/net_internals/source_filter_parser.js (right):

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
chrome/browser/resources/net_internals/source_filter_parser.js:19: // Text
filters are stored here a strings, and then added as a function on
On 2013/04/17 21:38:05, eroman wrote:
> "here a strings" --> "here as strings"

Done.  It's always the stuff I do last that has the most typos.  I'm sure
someone could learn something important from that.

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
chrome/browser/resources/net_internals/source_filter_parser.js:20: // the end,
for performance reason.
On 2013/04/17 21:38:05, eroman wrote:
> "for performance reason" --> "for performance reasons".

Done.

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
File chrome/browser/resources/net_internals/source_row.js (right):

https://codereview.chromium.org/13725016/diff/45001/chrome/browser/resources/...
chrome/browser/resources/net_internals/source_row.js:168: matchesFilter:
function(filter) {
On 2013/04/17 21:38:05, eroman wrote:
> Actually I think this is only used in one place -- perhaps can just delete
this
> function and have caller directly call filter.

Done.

https://codereview.chromium.org/13725016/diff/45001/chrome/test/data/webui/ne...
File chrome/test/data/webui/net_internals/events_view.js (right):

https://codereview.chromium.org/13725016/diff/45001/chrome/test/data/webui/ne...
chrome/test/data/webui/net_internals/events_view.js:187: { text: '-sort:"shoe
size"', matches: [true, true] },
On 2013/04/17 21:38:05, eroman wrote:
> I hope this is a pony horse shoe...

It's...umm...err...an ox shoe...  I hope you don't mind.

[mmenke, 2013-04-18 00:08:56]

Committed patchset #8 manually as r194731.