Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 13725007: Remove the ENABLE_JAVASCRIPT_I18N_API compile time flag. (Closed)

Created:
7 years, 8 months ago by Peter Beverloo
Modified:
7 years, 8 months ago
CC:
blink-reviews, dcarney, jochen (gone - plz use gerrit), haraken, abarth-chromium, danno
Visibility:
Public.

Description

Remove the ENABLE_JAVASCRIPT_I18N_API compile time flag. All platforms ship this. We'll continue to have the run-time flag because of the --disable-javascript-i18n-api command line flag. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Remove the flags altogether. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -46 lines) Patch
M Source/WebKit/chromium/features.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/public/WebRuntimeFeatures.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 2 3 4 1 chunk +0 lines, -16 lines 0 comments Download
M Source/bindings/v8/RuntimeEnabledFeatures.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
Source/bindings/v8/RuntimeEnabledFeatures.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/bindings/v8/V8DOMWindowShell.cpp View 1 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Beverloo
7 years, 8 months ago (2013-04-08 16:24:13 UTC) #1
eseidel
What does this even do? :) Can we remove the --disable? Is this still an ...
7 years, 8 months ago (2013-04-09 07:23:50 UTC) #2
jochen (gone - plz use gerrit)
+danno I think we can even drop the runtime flag
7 years, 8 months ago (2013-04-09 09:39:17 UTC) #3
jochen (gone - plz use gerrit)
+cira Do you know whether the command line flag to disable the v8-i18n extension is ...
7 years, 8 months ago (2013-04-11 14:23:43 UTC) #4
Nebojša Ćirić
Sorry didn't see it before. I don't think we need the flag anymore. The feature ...
7 years, 8 months ago (2013-04-15 17:54:23 UTC) #5
Peter Beverloo
Correct, Chromium for Android ships this as well. I'll remove the command line flag, and ...
7 years, 8 months ago (2013-04-15 21:11:56 UTC) #6
abarth-chromium
LGTM We can also land this patch (perhaps with the default set to "true"), then ...
7 years, 8 months ago (2013-04-15 23:56:51 UTC) #7
Peter Beverloo
7 years, 8 months ago (2013-04-23 13:25:44 UTC) #8
Apologies for the late reply.  I've uploaded two patches removing the plumbing
for both Chromium and Blink.  I tried updating this CL, but "git cl upload"
continued to complain that it couldn't find the base file.

Chromium side:
https://codereview.chromium.org/13843008/

Blink side:
https://codereview.chromium.org/14429004/

I'm abandoning this CL, but will refer to it in both new CLs for reference.

Powered by Google App Engine
This is Rietveld 408576698