Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1372473002: Add the ability to disable special automatic entities in impl/memory (Closed)

Created:
5 years, 2 months ago by iannucci
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add more docstring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -16 lines) Patch
M impl/memory/context.go View 1 chunk +4 lines, -0 lines 0 comments Download
M impl/memory/datastore.go View 3 chunks +6 lines, -4 lines 0 comments Download
M impl/memory/datastore_data.go View 7 chunks +45 lines, -12 lines 0 comments Download
M impl/memory/datastore_test.go View 2 chunks +15 lines, -0 lines 0 comments Download
M service/datastore/testable.go View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
iannucci
5 years, 2 months ago (2015-09-24 22:11:00 UTC) #1
Vadim Sh.
lgtm, but why?.. Please add more explanation to the doc string for why this is ...
5 years, 2 months ago (2015-09-24 22:15:27 UTC) #2
iannucci
better?
5 years, 2 months ago (2015-09-24 22:26:26 UTC) #3
Vadim Sh.
On 2015/09/24 22:26:26, iannucci wrote: > better? yeah, little bit
5 years, 2 months ago (2015-09-24 22:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372473002/20001
5 years, 2 months ago (2015-09-24 23:14:11 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 23:15:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/30614e988d402124209fc53bc78a8e44d4a704f6

Powered by Google App Engine
This is Rietveld 408576698