Avoid a race condition in the Origin Info Bubble UI.

Avoid a race condition in the Origin Info Bubble UI.

The "N cookies from this site" link gets updated in real time (to update the
value of N). That causes the link to lose click events and its tab index.
Solve the problem by only updating the link text, rather than destroying and
rebuilding the entire layout.

BUG=535587
Committed: https://crrev.com/adbece4bf16af98918c7f422a0bd1edec78d0865
Cr-Commit-Position: refs/heads/master@{#351173}

[palmer, 2015-09-24 21:20:51]

palmer@chromium.org changed reviewers:
+ felt@chromium.org, sadrul@chromium.org

[palmer, 2015-09-24 21:20:51]

felt: PTAL and see if you can live with this

sadrul: Any better ideas? :)

[palmer, 2015-09-28 18:08:35]

felt: PTAL, this is a real (and simple) fix thanks to sadrul.

[felt, 2015-09-28 20:47:40]

lgtm % question to make sure I understand

https://codereview.chromium.org/1372453002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
(right):

https://codereview.chromium.org/1372453002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:498:
cookie_dialog_link_->SetText(first_party_label_text);
So this has the effect of updating the text, even without building a new layout?
And then layout->Layout(site_data_content) tells it to refresh with the new
text?

[palmer, 2015-09-28 21:02:51]

https://codereview.chromium.org/1372453002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
(right):

https://codereview.chromium.org/1372453002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:498:
cookie_dialog_link_->SetText(first_party_label_text);
> So this has the effect of updating the text, even without building a new
layout?

That's right. Previously, we blew away all the child views,

    site_data_content_->RemoveAllChildViews(true);

and rebuilt all the child views and their layout, from scratch, every time.
(Sounds kind of slow, doesn't it!) All that, just to update the text of the link
(or, previously, the text labels). But with cookie_dialog_link_->SetText, we can
keep everything and just update the text. And then:

> And then layout->Layout(site_data_content) tells it to refresh with the new
> text?

Yep.

[palmer, 2015-09-28 21:03:19]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2015-09-28 21:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372453002/20001

[commit-bot: I haz the power, 2015-09-28 22:37:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-28 22:38:35]

Patchset 2 (id:??) landed as
https://crrev.com/adbece4bf16af98918c7f422a0bd1edec78d0865
Cr-Commit-Position: refs/heads/master@{#351173}