Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 137243003: Only run pylint on Windows in PRESUBMIT (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Only run pylint on Windows in PRESUBMIT As a slight improvement for making changes on Windows, at least run the pylint steps. The tests do not currently work with a variety of failures, but at least running pylint would have caught the regressions encountered here https://codereview.chromium.org/134313007/#msg19. R=maruel@chromium.org BUG=334953 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245420

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M PRESUBMIT.py View 1 1 chunk +20 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 11 months ago (2014-01-16 06:09:38 UTC) #1
M-A Ruel
lgtm with appropriate fixes https://codereview.chromium.org/137243003/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/137243003/diff/1/PRESUBMIT.py#newcode42 PRESUBMIT.py:42: if not sys.platform.startswith(('cygwin', 'win32')): if ...
6 years, 11 months ago (2014-01-17 02:12:26 UTC) #2
scottmg
https://codereview.chromium.org/137243003/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/137243003/diff/1/PRESUBMIT.py#newcode42 PRESUBMIT.py:42: if not sys.platform.startswith(('cygwin', 'win32')): On 2014/01/17 02:12:26, M-A Ruel ...
6 years, 11 months ago (2014-01-17 03:53:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/137243003/60001
6 years, 11 months ago (2014-01-17 03:53:33 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 03:55:45 UTC) #5
Message was sent while issue was closed.
Change committed as 245420

Powered by Google App Engine
This is Rietveld 408576698