Issue 13724006: Fix presubmit style warning for gdb-jit.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13724006: Fix presubmit style warning for gdb-jit.cc (Closed)

Created:
7 years, 8 months ago by wingo

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger, Jakob Kummerow

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Fix presubmit style warning for gdb-jit.cc For many moons now I've been seeing this warning when running make x64.release.check: /home/wingo/src/v8/src/gdb-jit.cc:632: Single-argument constructors should be marked explicit. [runtime/explicit] [5] This patch fixes it. BUG= Committed: http://code.google.com/p/v8/source/detail?r=14153

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gdb-jit.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 8 months ago (2013-04-05 15:11:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14153 (presubmit successful).

Expand Messages | Collapse Messages