Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 13724004: Remove the ENABLE_NOSNIFF compile-time flag. (Closed)

Created:
7 years, 8 months ago by Mike West
Modified:
7 years, 8 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Remove the ENABLE_NOSNIFF compile-time flag. This patch drops the fet instances of '#IFDEF ENABLE(NOSNIFF)' from the codebase. It shouldn't effect any web-visible behavior, as it was already enabled by default in Chromium. R=abarth@chromium.org,eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147700

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M Source/WebCore/dom/ScriptElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/cache/CachedScript.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/cache/CachedScript.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/network/HTTPParsers.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/network/HTTPParsers.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Tools/Scripts/webkitperl/FeatureList.pm View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Hi Adam, Eric, This patch drops the ENABLE_NOSNIFF flag. Would either of you mind taking ...
7 years, 8 months ago (2013-04-05 12:18:01 UTC) #1
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-05 17:29:51 UTC) #2
Mike West
7 years, 8 months ago (2013-04-05 23:18:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r147700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698