Move border-spacing related properties into CSSPropertyParser

Move border-spacing related properties into CSSPropertyParser

Move border-spacing related properties handling from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/327f58126894dc170bd2d80d042786a3fc41d293
Cr-Commit-Position: refs/heads/master@{#352852}

[rwlbuis, 2015-10-06 19:40:00]

rob.buis@samsung.com changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org

[rwlbuis, 2015-10-06 19:40:00]

PTAL. This seems a good example of easily getting rid of those
inShorthand()/m_currentShorthand checks and replace it with a more readable
solution.

[Timothy Loh, 2015-10-06 23:47:12]

lgtm, although maybe we should try and avoid parseShorthand ending up as a
gigantic switch statement

[Timothy Loh, 2015-10-07 00:20:51]

https://codereview.chromium.org/1372393008/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1372393008/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:842: if
(m_range.atEnd()) {
same comment as on the viewport descriptor patch, I think this would look better
if we yielded both properties at the end

[rwlbuis, 2015-10-07 14:47:06]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-10-07 14:47:06]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1372393008/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-10-07 14:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372393008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372393008/20001

[commit-bot: I haz the power, 2015-10-07 16:13:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-07 16:14:00]

Patchset 2 (id:??) landed as
https://crrev.com/327f58126894dc170bd2d80d042786a3fc41d293
Cr-Commit-Position: refs/heads/master@{#352852}

[rwlbuis, 2015-10-07 23:10:16]

On 2015/10/06 23:47:12, Timothy Loh wrote:
> lgtm, although maybe we should try and avoid parseShorthand ending up as a
> gigantic switch statement

Good point, I'll try to avoid this in future.