[Chromecast] Upgrade to new CMA backend API

chromecast/renderer/media/audio_pipeline.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROMECAST_MEDIA_CMA_PIPELINE_AUDIO_PIPELINE_H_
-#define CHROMECAST_MEDIA_CMA_PIPELINE_AUDIO_PIPELINE_H_
+#ifndef CHROMECAST_RENDERER_MEDIA_AUDIO_PIPELINE_H_
+#define CHROMECAST_RENDERER_MEDIA_AUDIO_PIPELINE_H_
 
 #include "base/macros.h"
 #include "chromecast/media/cma/pipeline/av_pipeline_client.h"
 
 namespace chromecast {
 namespace media {
 
 class AudioPipeline {

[slan, 2015/10/07 02:06:47]

I don't think this class needs to exist anymore. Since AudioPipelineProxy no
longer inherits from the same class as the browser-side AudioPipeline, this is
now pretty useless. IMO, we have two options:

1) AudioPipelineProxy does not inherit from any class, and its methods are made
virtual for mocking in unittests.

2) AudioPipelineProxy becomes a pure virtual interface, and we rename the
existing implemented class to AudioPipelineProxyImpl.

I think I prefer #1 for simplicity, and to reduce the complexity of this stack.
The exact same thing applies to VideoPipeline.

[kmackay, 2015/10/07 16:37:58]

Done.

  public:
   AudioPipeline();
   virtual ~AudioPipeline();
 
   // Set the audio client.
   virtual void SetClient(const AvPipelineClient& client) = 0;
 
   // Set the stream volume.
   // - A value of 1.0 is the neutral value.
   // - |volume|=0.0 mutes the stream.
   virtual void SetVolume(float volume) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AudioPipeline);
 };
 
 }  // namespace media
 }  // namespace chromecast
 
-#endif  // CHROMECAST_MEDIA_CMA_PIPELINE_AUDIO_PIPELINE_H_
+#endif  // CHROMECAST_RENDERER_MEDIA_AUDIO_PIPELINE_H_